Sign upLogin

airbnb/superset

View on GitHub
Star
superset/migrations/versions/2022-04-01_14-38_a9422eeaae74_new_dataset_models_take_2.py

Summary

Maintainability
F
3 days
Test Coverage

File 2022-04-01_14-38_a9422eeaae74_new_dataset_models_take_2.py has 750 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
Severity: Major
Found in superset/migrations/versions/2022-04-01_14-38_a9422eeaae74_new_dataset_models_take_2.py - About 1 day to fix

    Function postprocess_columns has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
    Open

    def postprocess_columns(session: Session) -> None:
    """
    At this step, we will
      - Add engine specific quotes to `expression` of physical columns
      - Tuck some extra metadata to `extra_json`
    Severity: Minor
    Found in superset/migrations/versions/2022-04-01_14-38_a9422eeaae74_new_dataset_models_take_2.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function postprocess_datasets has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

    def postprocess_datasets(session: Session) -> None:
    """
    Postprocess datasets after insertion to
      - Quote table names for physical datasets (if needed)
      - Link referenced tables to virtual datasets
    Severity: Minor
    Found in superset/migrations/versions/2022-04-01_14-38_a9422eeaae74_new_dataset_models_take_2.py - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if is_physical and drivername:
                        quoted_expression = get_identifier_quoter(drivername)(
                            column_name
                        )
                        if quoted_expression != column_name:
    Severity: Major
    Found in superset/migrations/versions/2022-04-01_14-38_a9422eeaae74_new_dataset_models_take_2.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status