Sign upLogin

airbnb/superset

View on GitHub
Star
superset/utils/pandas_postprocessing/contribution.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function get_column_groups has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

def get_column_groups(
    df: DataFrame, time_shifts: list[str] | None, rename_columns: list[str]
) -> dict[str, Any]:
    """
    Group columns based on whether they have a time shift.
Severity: Minor
Found in superset/utils/pandas_postprocessing/contribution.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function contribution has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def contribution(
    df: DataFrame,
    orientation: (
        PostProcessingContributionOrientation | None
    ) = PostProcessingContributionOrientation.COLUMN,
Severity: Minor
Found in superset/utils/pandas_postprocessing/contribution.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function contribution has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def contribution(
Severity: Minor
Found in superset/utils/pandas_postprocessing/contribution.py - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status