Sign upLogin

akrawchyk/amweekly

View on GitHub
Star
amweekly/shares/jobs.py

Summary

Maintainability
A
35 mins
Test Coverage

Function get_og_object has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def get_og_object(id):
    if settings.FACEBOOK_APP_ID is '' or \
       settings.FACEBOOK_APP_SECRET is '':
        raise ImproperlyConfigured(
            'FACEBOOK_APP_ID or FACEBOOK_APP_SECRET not configured')
Severity: Minor
Found in amweekly/shares/jobs.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status