Sign upLogin

akretion/locomotive_shopinvader

View on GitHub
Star

Showing 15 of 15 total issues

Method parse_response has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def parse_response(response)
      headers = response.headers
      if headers['content-type'] == 'application/json'
        res = JSON.parse(response.body)
        if res.include?('set_session')
Severity: Minor
Found in lib/shop_invader/services/erp_service.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_params has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def build_params(conditions)
      { numericFilters: [], facetFilters: [] }.tap do |params|
        conditions.each do |key, value|
          name, op = key.split('.')
          build_attr(name, value).each do | name, value |
Severity: Minor
Found in lib/shop_invader/services/algolia_service.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_response has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def parse_response(response)
      headers = response.headers
      if headers['content-type'] == 'application/json'
        res = JSON.parse(response.body)
        if res.include?('set_session')
Severity: Minor
Found in lib/shop_invader/services/erp_service.rb - About 1 hr to fix

    Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(source, page, per_page)
      if source.respond_to?(:paginate, true)
        @current_page, @per_page = page || 1, per_page || DEFAULT_PER_PAGE

        collection = source.send(:paginate, @current_page, @per_page)
    Severity: Minor
    Found in lib/shop_invader/steam_patches.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method subscribe_to_steam_notifications has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.subscribe_to_steam_notifications

    # new signups
    ActiveSupport::Notifications.subscribe('steam.auth.signed_up') do |name, start, finish, id, payload|
      service = Locomotive::Steam::Services.build_instance(payload[:request])
    Severity: Minor
    Found in lib/shop_invader.rb - About 1 hr to fix

      Method initialize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                def initialize(tag_name, markup, options)
            syntax_error = false
            if markup =~ SyntaxAsWith
              @method_name, service_path, @to = $1, $2, $3
              @params = parse_options_from_string($4)
      Severity: Minor
      Found in lib/shop_invader/liquid/tags/erp.rb - About 1 hr to fix

        Method _process_redirection has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def _process_redirection(response)
        if response.status == 200
          data = erp.parse_response(response)
          if data.include?('redirect_to')
            redirect_to data['redirect_to'], 302
        Severity: Minor
        Found in lib/shop_invader/middlewares/erp_proxy.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                  def initialize(tag_name, markup, options)
            syntax_error = false
            if markup =~ SyntaxAsWith
              @method_name, service_path, @to = $1, $2, $3
              @params = parse_options_from_string($4)
        Severity: Minor
        Found in lib/shop_invader/liquid/tags/erp.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def initialize(request, site, session, customer, locale, cookie_service)
        Severity: Minor
        Found in lib/shop_invader/services/erp_service.rb - About 45 mins to fix

          Method subscribe_to_steam_notifications has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.subscribe_to_steam_notifications

    # new signups
    ActiveSupport::Notifications.subscribe('steam.auth.signed_up') do |name, start, finish, id, payload|
      service = Locomotive::Steam::Services.build_instance(payload[:request])
          Severity: Minor
          Found in lib/shop_invader.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method before_method has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def before_method(meth)
          if ONLY_SESSION_STORE.include?(meth)
            data = service.erp.is_cached?(meth) && service.erp.read_from_cache(meth)
            if ONLY_ONE_TIME.include?(meth)
              service.erp.clear_cache(meth)
          Severity: Minor
          Found in lib/shop_invader/liquid/drops/store.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method _call has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def _call
        if env['steam.path'].start_with?('invader/')
          path = env['steam.path'].sub('invader/', '')
          response = erp.call_without_parsing(env['REQUEST_METHOD'], path, params)
          if response.status == 200 && response.headers["content-type"] != "application/json"
          Severity: Minor
          Found in lib/shop_invader/middlewares/erp_proxy.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method set_200_header has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def set_200_header(headers)
        headers['Cache-Control'] = env['steam.cache_control'] || "max-age=0, private, must-revalidate"

        # Always inject a vary on accept-language for the header
        # if the site have multiple lang on the home page
          Severity: Minor
          Found in lib/shop_invader/middlewares/helpers.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              ActiveSupport::Notifications.subscribe('steam.auth.reset_password') do |name, start, finish, id, payload|
      service = Locomotive::Steam::Services.build_instance(payload[:request])
      if should_notify_erp(payload)
        payload[:request].env['authenticated_entry'] = payload[:entry]
        service.erp_auth.reset_password(payload[:entry])
          Severity: Minor
          Found in lib/shop_invader.rb and 1 other location - About 35 mins to fix
          lib/shop_invader.rb on lines 90..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              ActiveSupport::Notifications.subscribe('steam.auth.signed_in') do |name, start, finish, id, payload|
      service = Locomotive::Steam::Services.build_instance(payload[:request])
      if should_notify_erp(payload)
        payload[:request].env['authenticated_entry'] = payload[:entry]
        service.erp_auth.signed_in(payload[:entry])
          Severity: Minor
          Found in lib/shop_invader.rb and 1 other location - About 35 mins to fix
          lib/shop_invader.rb on lines 98..102

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language