Sign upLogin

akretion/ooor

View on GitHub
Star
lib/ooor/errors.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method filter_password has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def filter_password(args)
      if args[0].is_a?(String) && args[2].is_a?(String) && (args[1].is_a?(Integer) || (args[1].respond_to?(:to_i) && args[1].to_i != 0))
        args[2] = "####"
      end
      args.map! do |arg|
Severity: Minor
Found in lib/ooor/errors.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def self.build(faultCode, faultString, method, *args)
      if faultCode =~ /AttributeError: / || faultCode =~ /object has no attribute/
        return UnknownAttributeOrAssociationError.new("method: #{method} - args: #{args.inspect}", faultCode, faultString)
      elsif faultCode =~ /TypeError: /
        return TypeError.new(method, faultCode, faultString, *args)
Severity: Minor
Found in lib/ooor/errors.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return new(method, faultCode, faultString, *args)
Severity: Major
Found in lib/ooor/errors.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return UnAuthorizedError.new(method, faultCode, faultString, *args)
    Severity: Major
    Found in lib/ooor/errors.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return SessionExpiredError.new(method, faultCode, faultString, *args)
      Severity: Major
      Found in lib/ooor/errors.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return InvalidSessionError.new(method, faultCode, faultString, *args)
        Severity: Major
        Found in lib/ooor/errors.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status