Sign upLogin

albertyw/apple_vpp

View on GitHub
Star
lib/apple_vpp/url_service.rb

Summary

Maintainability
A
0 mins
Test Coverage
F
32%

Assignment Branch Condition size for refresh is too high. [24.76/15]
Open

    def refresh
      url = "#{SERVICE_URL}VPPServiceConfigSrv"
      resp = Request.submit url

      @associate_license_srv_url              = resp["associateLicenseSrvUrl"]
Severity: Minor
Found in lib/apple_vpp/url_service.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Freeze mutable objects assigned to constants.
Open

    SERVICE_URL = "https://vpp.itunes.apple.com/WebObjects/MZFinance.woa/wa/"
Severity: Minor
Found in lib/apple_vpp/url_service.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

There are no issues that match your filters.

Category
Status