Sign upLogin

albertyw/ios_config_profile

View on GitHub
Star

Showing 4 of 15 total issues

Method available_supervised_payloads has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.available_supervised_payloads
      # key => [english description, default, (options)]
      {
        "allowiTunes" => ["Allow iTunes Music Store", true],
        "allowVideoConferencing" => ["Allow video conferencing", true],
Severity: Minor
Found in lib/ios_config_profile/device/restrictions_payload.rb - About 1 hr to fix

    Method available_payloads has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.available_payloads
      # key => [english description, default, (options)]
      {
        "allowAssistant" => ["Allow Siri", true],
        "allowAssistantWhileLocked" => ["Allow Siri while device is locked", true],
    Severity: Minor
    Found in lib/ios_config_profile/device/restrictions_payload.rb - About 1 hr to fix

      Method get_vendor_config has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_vendor_config
      if vpn_config[:vpn_type] == "L2TP"
        get_l2tp_config
      elsif vpn_config[:vpn_type] == "PPTP"
        raise NotImplementedError
      Severity: Minor
      Found in lib/ios_config_profile/device/vpn_payload.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method generate_restrictions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def generate_restrictions(custom_values)
      if not custom_values.is_a? Hash
        custom_values = Hash.new
      end
      default_payload = restrictions_payload
      Severity: Minor
      Found in lib/ios_config_profile/device/restrictions_payload.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language