Sign upLogin

aleks-pol/project-lvl2-s463

View on GitHub
Star

Showing 8 of 8 total issues

Function buildTree has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const buildTree = (before, after, parent) => {
  const beforeKeys = Object.keys(before);
  const afterKeys = Object.keys(after);
  const mapKeys = key => {
    const beforeHasKey = has(key, before);
Severity: Major
Found in src/index.js - About 2 hrs to fix

    Function mapKeys has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const mapKeys = key => {
    const beforeHasKey = has(key, before);
    const afterHasKey = has(key, after);
    if (before[key] === after[key]) {
      return {
    Severity: Minor
    Found in src/index.js - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      test.each(formats)('gendiff plain %s', fileExt => {
  expect(
    genDiff(
      `__tests__/__fixtures__/before.${fileExt}`,
      `__tests__/__fixtures__/after.${fileExt}`,
      Severity: Major
      Found in __tests__/gendiff.test.js and 2 other locations - About 1 hr to fix
      __tests__/gendiff.test.js on lines 20..28
      __tests__/gendiff.test.js on lines 38..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      test.each(formats)('gendiff %s', fileExt => {
  expect(
    genDiff(
      `__tests__/__fixtures__/before.${fileExt}`,
      `__tests__/__fixtures__/after.${fileExt}`,
      Severity: Major
      Found in __tests__/gendiff.test.js and 2 other locations - About 1 hr to fix
      __tests__/gendiff.test.js on lines 29..37
      __tests__/gendiff.test.js on lines 38..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      test.each(formats)('gendiff json %s', fileExt => {
  expect(
    genDiff(
      `__tests__/__fixtures__/before.${fileExt}`,
      `__tests__/__fixtures__/after.${fileExt}`,
      Severity: Major
      Found in __tests__/gendiff.test.js and 2 other locations - About 1 hr to fix
      __tests__/gendiff.test.js on lines 20..28
      __tests__/gendiff.test.js on lines 29..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function buildTree has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      const buildTree = (before, after, parent) => {
  const beforeKeys = Object.keys(before);
  const afterKeys = Object.keys(after);
  const mapKeys = key => {
    const beforeHasKey = has(key, before);
      Severity: Minor
      Found in src/index.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function iter has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const iter = (tree, depth) => {
    const spaceIndent = ' '.repeat(depth);
    const equalsSpaceIndent = ' '.repeat(depth + 2);
    const buildString = item => {
      const { oldValue, newValue, type, children, key } = item;
      Severity: Minor
      Found in src/renderers/tree.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

            return {
      key,
      parent,
      type: 'changed',
      oldValue: before[key],
        Severity: Major
        Found in src/index.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language