Sign upLogin

alekzonder/maf

View on GitHub
Star

Showing 90 of 90 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    Promise.all(createPromises)
                        .then((data) => {
                            resolve({collection: this._collectionName, indexes: data});
                        })
                        .catch((error) => {
Severity: Major
Found in src/Model/Mongodb/index.js and 1 other location - About 2 hrs to fix
src/Model/Tingodb/index.js on lines 96..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            Promise.all(promises)
                .then((data) => {
                    resolve({collection: this._collectionName, indexes: data});
                })
                .catch((error) => {
Severity: Major
Found in src/Model/Tingodb/index.js and 1 other location - About 2 hrs to fix
src/Model/Mongodb/index.js on lines 125..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            request.end((err, res) => {
                if (err) {
                    var e = this._processError(err);

                    timer.error(e);
Severity: Major
Found in src/Rest/Client/index.js and 1 other location - About 2 hrs to fix
src/Rest/Client/index.js on lines 44..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            request.end((err, res) => {
                if (err) {
                    var e = this._processError(err);

                    timer.error(e);
Severity: Major
Found in src/Rest/Client/index.js and 1 other location - About 2 hrs to fix
src/Rest/Client/index.js on lines 89..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (logger, options) {

    return new Promise((resolve, reject) => {
        if (!options.consul || !options.consul.key) {
            return resolve(null);
Severity: Major
Found in src/Service/Config/getConfigFromConsul.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        init () {

        if (!this._collectionName) {
            throw new this.Error(this.Error.CODES.NO_COLLECTION_NAME);
        }
    Severity: Major
    Found in src/Model/Mongodb/index.js and 1 other location - About 2 hrs to fix
    src/Model/Tingodb/index.js on lines 49..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        init () {

        if (!this._collectionName) {
            throw new this.Error(this.Error.CODES.NO_COLLECTION_NAME);
        }
    Severity: Major
    Found in src/Model/Tingodb/index.js and 1 other location - About 2 hrs to fix
    src/Model/Mongodb/index.js on lines 46..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File Abstract.js has 256 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var path = require('path');

var _ = require(path.resolve(__dirname, '../vendors/lodash'));
var uuid = require(path.resolve(__dirname, '../vendors/uuid'));
    Severity: Minor
    Found in src/Api/Abstract.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (method == 'GET') {
                if (!methodData.schema.query) {
                    methodData.schema.query = {};
                }
      Severity: Major
      Found in src/Rest/Middleware/AuthToken.js and 1 other location - About 2 hrs to fix
      src/Rest/Middleware/AuthToken.js on lines 34..40

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  } else {
                if (!methodData.schema.body) {
                    methodData.schema.body = {};
                }
      Severity: Major
      Found in src/Rest/Middleware/AuthToken.js and 1 other location - About 2 hrs to fix
      src/Rest/Middleware/AuthToken.js on lines 28..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function check has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          check (logger) {

        if (this._entity && this._error.entity !== this._entity) {
            return false;
        }
      Severity: Minor
      Found in src/Error/CheckChain.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function (logger, init) {

    return new Promise((resolve, reject) => {

        process.on('unhandledRejection', function (err) {
      Severity: Minor
      Found in src/Service/Init/Repl.js - About 2 hrs to fix

        Function exports has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function (logger, di, apiClasses, createFunctions) {


    var original = {
        di: di,
        Severity: Minor
        Found in src/Api/createCollection/createProxy.js - About 1 hr to fix

          Function updateByName has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              updateByName (name, data) {

        return new Promise((resolve, reject) => {

            var timer = this._createTimer(this.entity + ':updateByName');
          Severity: Minor
          Found in src/Api/Abstract.js - About 1 hr to fix

            Function updateById has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                updateById (id, data) {

        return new Promise((resolve, reject) => {

            var timer = this._createTimer(this.entity + ':updateById');
            Severity: Minor
            Found in src/Api/Abstract.js - About 1 hr to fix

              Function exports has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = function (di, modelClasses, createFn) {

    return new Promise((resolve/* , reject */) => {

        var models = {};
              Severity: Minor
              Found in src/Model/createCollection.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _init has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                  _init () {
        var that = this;

        var makeSimpleStep = function (stepName) {
            return function (value) {
              Severity: Minor
              Found in src/Chain.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function find has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  find (filter, fields) {

        var timer = this._createTimer('find');

        fields = this._prepareFields(fields);
              Severity: Minor
              Found in src/Model/Tingodb/index.js - About 1 hr to fix

                Function middleware has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        middleware: (req, res, next) => {

            var di = req.di;

            if (checkToken) {
                Severity: Minor
                Found in src/Rest/Middleware/AuthToken.js - About 1 hr to fix

                  Function findOneAndUpdate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      findOneAndUpdate (filter, update, options) {

        var timer = this._createTimer('findOneAndUpdate');

        var queryOptions = {
                  Severity: Minor
                  Found in src/Model/Tingodb/index.js - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language