Sign upLogin

alertlogic/lita-alertlogic

View on GitHub
Star

Showing 27 of 27 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      def lm_sources_list(response)
        customer_id = valid_cid(response.match_data[1])
        return response.reply(t('validation.customer_id')) if customer_id.nil?
        response.reply(t('warn.standby'))
Severity: Major
Found in lib/lita/handlers/alertlogic_log_manager.rb and 2 other locations - About 1 hr to fix
lib/lita/handlers/alertlogic_log_manager.rb on lines 119..144
lib/lita/handlers/alertlogic_threat_manager.rb on lines 192..215

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      def protectedhosts_list(response)
        customer_id = valid_cid(response.match_data[1])
        return response.reply(t('validation.customer_id')) if customer_id.nil?
        response.reply(t('warn.standby'))
Severity: Major
Found in lib/lita/handlers/alertlogic_threat_manager.rb and 2 other locations - About 1 hr to fix
lib/lita/handlers/alertlogic_log_manager.rb on lines 119..144
lib/lita/handlers/alertlogic_log_manager.rb on lines 166..191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      def lm_hosts_list(response)
        customer_id = valid_cid(response.match_data[1])
        return response.reply(t('validation.customer_id')) if customer_id.nil?
        response.reply(t('warn.standby'))
Severity: Major
Found in lib/lita/handlers/alertlogic_log_manager.rb and 2 other locations - About 1 hr to fix
lib/lita/handlers/alertlogic_log_manager.rb on lines 166..191
lib/lita/handlers/alertlogic_threat_manager.rb on lines 192..215

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def tm_hosts_list(response)
        customer_id = valid_cid(response.match_data[1])
        response.reply(t('warn.standby'))

        params = {
Severity: Major
Found in lib/lita/handlers/alertlogic_threat_manager.rb and 1 other location - About 1 hr to fix
lib/lita/handlers/alertlogic_threat_manager.rb on lines 164..188

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def tm_policies_list(response)
        customer_id = valid_cid(response.match_data[1])
        response.reply(t('warn.standby'))

        params = {
Severity: Major
Found in lib/lita/handlers/alertlogic_threat_manager.rb and 1 other location - About 1 hr to fix
lib/lita/handlers/alertlogic_threat_manager.rb on lines 136..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method process_lm_hosts has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def process_lm_hosts(customer_id, hosts)
      headers    = [
        'Host Name',
        'Host Type',
        'Host ID',
Severity: Minor
Found in lib/alertlogic_helper/log_manager.rb - About 1 hr to fix

    Method process_tm_hosts has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def process_tm_hosts(customer_id, hosts)
      headers = [
        'Host Name',
        'Host ID',
        'Type',
    Severity: Minor
    Found in lib/alertlogic_helper/threat_manager.rb - About 1 hr to fix

      Method agent_policy_summary has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def agent_policy_summary(customer_id)
      data    = []
      reply   = "/code Policy/Agents counts for customer: #{customer_id} \n"
      headers = [
        'Policy Name',
      Severity: Minor
      Found in lib/alertlogic_helper/agents.rb - About 1 hr to fix

        Method process_protectedhosts_list has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def process_protectedhosts_list(customer_id, phosts)
      phost_list = phosts['protectedhosts']
      reply_head = "/code Protectedhosts Status for customer: #{customer_id} \n"
      headers    = %w(Name VPC Status)
      data   = []
        Severity: Minor
        Found in lib/alertlogic_helper/threat_manager.rb - About 1 hr to fix

          Method process_lm_sources has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def process_lm_sources(customer_id, sources)
      headers      = [
        'Source Name',
        'Source Type',
        'IP Address',
          Severity: Minor
          Found in lib/alertlogic_helper/log_manager.rb - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def lm_appliance_list(response)
        customer_id   = valid_cid(response.match_data[1])
        return response.reply(t('validation.customer_id')) if customer_id.nil?
        appliance_list = []
        customers      = get_customer_ids(customer_id)
            Severity: Major
            Found in lib/lita/handlers/alertlogic_log_manager.rb and 1 other location - About 1 hr to fix
            lib/lita/handlers/alertlogic_threat_manager.rb on lines 114..133

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def tm_appliance_list(response)
        customer_id = valid_cid(response.match_data[1])
        return response.reply(t('validation.customer_id')) if customer_id.nil?
        appliance_list = []
        customers = get_customer_ids(customer_id)
            Severity: Major
            Found in lib/lita/handlers/alertlogic_threat_manager.rb and 1 other location - About 1 hr to fix
            lib/lita/handlers/alertlogic_log_manager.rb on lines 68..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if !host['host']['metadata'].nil?
          ipv4 = host['host']['metadata']['local_ipv4']
        else
          ipv4 = ''
        end
            Severity: Major
            Found in lib/alertlogic_helper/threat_manager.rb and 1 other location - About 1 hr to fix
            lib/alertlogic_helper/log_manager.rb on lines 21..35

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if !host['host']['metadata'].nil?
          ipv4 = host['host']['metadata']['local_ipv4']
        else
          ipv4 = ''
        end
            Severity: Major
            Found in lib/alertlogic_helper/log_manager.rb and 1 other location - About 1 hr to fix
            lib/alertlogic_helper/threat_manager.rb on lines 59..73

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method process_protectedhosts_list has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def process_protectedhosts_list(customer_id, phosts)
      phost_list = phosts['protectedhosts']
      reply_head = "/code Protectedhosts Status for customer: #{customer_id} \n"
      headers    = %w(Name VPC Status)
      data   = []
            Severity: Minor
            Found in lib/alertlogic_helper/threat_manager.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method process_protectedhosts has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def process_protectedhosts(customer_id, phosts)
      phost_list = phosts['protectedhosts']
      reply      = "/code Protectedhosts Status for customer: #{customer_id} \n"
      ok         = 0
      error      = 0
            Severity: Minor
            Found in lib/alertlogic_helper/threat_manager.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method process_tm_policies has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def process_tm_policies(customer_id, policies)
      headers = [
        'Policy ID',
        'Name',
        'Appliance Assignment',
            Severity: Minor
            Found in lib/alertlogic_helper/threat_manager.rb - About 1 hr to fix

              Method agent_appliance_summary has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def agent_appliance_summary(customer_id)
      data    = []
      reply   = "/code Appliance/Agents counts for customer: #{customer_id} \n"
      headers = [
        'Appliance Name',
              Severity: Minor
              Found in lib/alertlogic_helper/agents.rb - About 1 hr to fix

                Method process_tm_hosts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def process_tm_hosts(customer_id, hosts)
      headers = [
        'Host Name',
        'Host ID',
        'Type',
                Severity: Minor
                Found in lib/alertlogic_helper/threat_manager.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method process_tm_policies has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def process_tm_policies(customer_id, policies)
      headers = [
        'Policy ID',
        'Name',
        'Appliance Assignment',
                Severity: Minor
                Found in lib/alertlogic_helper/threat_manager.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language