Sign upLogin

alex-taxiera/eris-boiler

View on GitHub
Star

Showing 10 of 17 total issues

Function constructor has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor () {
    super({
      name: 'migrations',
      subActions: [
        new Action({
Severity: Major
Found in cli/main/actions/migrations.js - About 4 hrs to fix

    Function _processCommandResponse has a Cognitive Complexity of 26 (exceeds 10 allowed). Consider refactoring.
    Open

      async _processCommandResponse (bot, context, response) {
    const {
      msg,
      command
    } = context
    Severity: Minor
    Found in lib/orator/index.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _processCommandResponse has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async _processCommandResponse (bot, context, response) {
    const {
      msg,
      command
    } = context
    Severity: Major
    Found in lib/orator/index.js - About 2 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              new Action({
          name: 'generate',
          async run (params) {
            const migration = params.slice(1)[0]
      Severity: Major
      Found in cli/main/actions/migrations.js and 2 other locations - About 2 hrs to fix
      cli/main/actions/migrations.js on lines 29..43
      cli/main/actions/migrations.js on lines 44..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              new Action({
          name: 'down',
          async run (params) {
            const migration = params.slice(1)[0]
      Severity: Major
      Found in cli/main/actions/migrations.js and 2 other locations - About 2 hrs to fix
      cli/main/actions/migrations.js on lines 14..28
      cli/main/actions/migrations.js on lines 29..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              new Action({
          name: 'up',
          async run (params) {
            const migration = params.slice(1)[0]
      Severity: Major
      Found in cli/main/actions/migrations.js and 2 other locations - About 2 hrs to fix
      cli/main/actions/migrations.js on lines 14..28
      cli/main/actions/migrations.js on lines 44..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function _tryToExecute has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async _tryToExecute (bot, context) {
    const {
      command,
      params
    } = context
      Severity: Minor
      Found in lib/orator/index.js - About 1 hr to fix

        Function _whereBuilder has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _whereBuilder (query, builder) {
      let conditions = Object.entries(query.conditions)
      const whereNots = conditions
        .filter(([ prop, { type } ]) => type === 'notEqualTo')
      conditions = conditions
        Severity: Minor
        Found in lib/sql-manager/index.js - About 1 hr to fix

          Function _loadFiles has a Cognitive Complexity of 14 (exceeds 10 allowed). Consider refactoring.
          Open

            async _loadFiles (path) {
    const file = await stat(path)
    const files = file.isDirectory() ? await readdir(path) : [ '' ]
    const res = []
    for (const fd of files) {
          Severity: Minor
          Found in lib/data-client/index.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _parseParamsForCommand has a Cognitive Complexity of 13 (exceeds 10 allowed). Consider refactoring.
          Open

            async _parseParamsForCommand (params, msg, bot) {
    const first = params.shift()
    let cmd
    if (first === bot.user.id && params.length > 0) {
      cmd = params.shift()
          Severity: Minor
          Found in lib/orator/index.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language