Sign upLogin

alexbrjo/MolassOS

View on GitHub
Star

Showing 185 of 185 total issues

Function assemble has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

var assemble = function (src, size) {

    /** The Project Control group */
    var pcGroup = new RegExp("^(JMP|RET|CALL)$|^[JRC]{1}(NZ|NC|PO|P|Z|P|PE|M)$");
    /** The math group, needs immed value */
Severity: Minor
Found in src/asm/Assemble.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function MolassesRegisters has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

function MolassesRegisters () {
    return {
        memory: null,
        /**
         * The 8-bit A (Accumulator) Register
Severity: Minor
Found in src/hardware/Register.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function assemble has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var assemble = function (src, size) {

    /** The Project Control group */
    var pcGroup = new RegExp("^(JMP|RET|CALL)$|^[JRC]{1}(NZ|NC|PO|P|Z|P|PE|M)$");
    /** The math group, needs immed value */
Severity: Major
Found in src/asm/Assemble.js - About 4 hrs to fix

    Function Memory has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    function Memory (s, mem_type) {
    
    // Validate size parameter
    if (s < 1) {
        throw new Error("Memory must have at least 1 byte.");
    Severity: Minor
    Found in src/hardware/Memory.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function MolassesRegisters has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function MolassesRegisters () {
    return {
        memory: null,
        /**
         * The 8-bit A (Accumulator) Register
    Severity: Major
    Found in src/hardware/Register.js - About 3 hrs to fix

      `` has 30 functions (exceeds 20 allowed). Consider refactoring.
      Open

          return {
        memory: null,
        /**
         * The 8-bit A (Accumulator) Register
         */
      Severity: Minor
      Found in src/hardware/Register.js - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        operation[operation.STAX_B] = function (reg) {
    var add = reg.B + reg.C * 256;
    reg.memory.write(add, Math.floor(reg.A / 256));
    reg.memory.write(add + 1, reg.A % 256);
};
        Severity: Major
        Found in src/hardware/instructions/MulitReg.js and 1 other location - About 3 hrs to fix
        src/hardware/instructions/MulitReg.js on lines 27..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        operation[operation.STAX_D] = function (reg) {
    var add = reg.D + reg.E * 256;
    reg.memory.write(add, Math.floor(reg.A / 256));
    reg.memory.write(add + 1, reg.A % 256);
};
        Severity: Major
        Found in src/hardware/instructions/MulitReg.js and 1 other location - About 3 hrs to fix
        src/hardware/instructions/MulitReg.js on lines 21..25

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exports has 84 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function (grunt) {
    grunt.initConfig({
        pkg: grunt.file.readJSON('package.json'),
        concat: {
            options: {
        Severity: Major
        Found in Gruntfile.js - About 3 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          operation[operation.LDA] = function (reg, l, h) {
    var add = h * 256 + l;
    reg.L = reg.memory.read(add);
    reg.H = reg.memory.read(add + 1);
};
          Severity: Major
          Found in src/hardware/instructions/MulitReg.js and 1 other location - About 2 hrs to fix
          src/hardware/instructions/MulitReg.js on lines 49..53

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          operation[operation.LHLD] = function (reg, l, h) {
    var add = h * 256 + l;
    reg.L = reg.memory.read(add);
    reg.H = reg.memory.read(add + 1);
};
          Severity: Major
          Found in src/hardware/instructions/MulitReg.js and 1 other location - About 2 hrs to fix
          src/hardware/instructions/MulitReg.js on lines 61..65

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          operation[operation.LDAX_D] = function (reg) {
    var add = reg.D + reg.E * 256;
    reg.A = reg.memory.read(add) + reg.memory.read(add + 1);
};
          Severity: Major
          Found in src/hardware/instructions/MulitReg.js and 1 other location - About 2 hrs to fix
          src/hardware/instructions/MulitReg.js on lines 33..36

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          operation[operation.LDAX_B] = function (reg) {
    var add = reg.B + reg.C * 256;
    reg.A = reg.memory.read(add) + reg.memory.read(add + 1);
};
          Severity: Major
          Found in src/hardware/instructions/MulitReg.js and 1 other location - About 2 hrs to fix
          src/hardware/instructions/MulitReg.js on lines 38..41

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function Memory has 64 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function Memory (s, mem_type) {
    
    // Validate size parameter
    if (s < 1) {
        throw new Error("Memory must have at least 1 byte.");
          Severity: Major
          Found in src/hardware/Memory.js - About 2 hrs to fix

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            operation[operation.CZ] = function (reg, l, h) {
    if (reg.ZERO === 1) {
        reg.PUSH(l * 0x100 + h);
    } else {
        reg.PC += 3;
            Severity: Major
            Found in src/hardware/instructions/Call.js and 7 other locations - About 1 hr to fix
            src/hardware/instructions/Call.js on lines 14..20
            src/hardware/instructions/Call.js on lines 22..28
            src/hardware/instructions/Call.js on lines 30..36
            src/hardware/instructions/Call.js on lines 38..44
            src/hardware/instructions/Call.js on lines 46..52
            src/hardware/instructions/Call.js on lines 62..68
            src/hardware/instructions/Call.js on lines 70..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            operation[operation.CPO] = function (reg, l, h) {
    if (reg.PARITY === 0) {
        reg.PUSH(l * 0x100 + h);
    } else { 
        reg.PC += 3;
            Severity: Major
            Found in src/hardware/instructions/Call.js and 7 other locations - About 1 hr to fix
            src/hardware/instructions/Call.js on lines 14..20
            src/hardware/instructions/Call.js on lines 22..28
            src/hardware/instructions/Call.js on lines 30..36
            src/hardware/instructions/Call.js on lines 46..52
            src/hardware/instructions/Call.js on lines 54..60
            src/hardware/instructions/Call.js on lines 62..68
            src/hardware/instructions/Call.js on lines 70..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            operation[operation.CNZ] = function (reg, l, h) {
    if (reg.ZERO === 0) {
        reg.PUSH(l * 0x100 + h);
    } else {
        reg.PC += 3;
            Severity: Major
            Found in src/hardware/instructions/Call.js and 7 other locations - About 1 hr to fix
            src/hardware/instructions/Call.js on lines 14..20
            src/hardware/instructions/Call.js on lines 30..36
            src/hardware/instructions/Call.js on lines 38..44
            src/hardware/instructions/Call.js on lines 46..52
            src/hardware/instructions/Call.js on lines 54..60
            src/hardware/instructions/Call.js on lines 62..68
            src/hardware/instructions/Call.js on lines 70..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            operation[operation.CM] = function (reg, l, h) {
    if (reg.SIGN === 1) {
        reg.PUSH(l * 0x100 + h);
    } else {
        reg.PC += 3;
            Severity: Major
            Found in src/hardware/instructions/Call.js and 7 other locations - About 1 hr to fix
            src/hardware/instructions/Call.js on lines 14..20
            src/hardware/instructions/Call.js on lines 22..28
            src/hardware/instructions/Call.js on lines 30..36
            src/hardware/instructions/Call.js on lines 38..44
            src/hardware/instructions/Call.js on lines 46..52
            src/hardware/instructions/Call.js on lines 54..60
            src/hardware/instructions/Call.js on lines 70..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            operation[operation.CNC] = function (reg, l, h) {
    if (reg.CARRY === 0) {
        reg.PUSH(l * 0x100 + h);
    } else {
        reg.PC += 3;
            Severity: Major
            Found in src/hardware/instructions/Call.js and 7 other locations - About 1 hr to fix
            src/hardware/instructions/Call.js on lines 22..28
            src/hardware/instructions/Call.js on lines 30..36
            src/hardware/instructions/Call.js on lines 38..44
            src/hardware/instructions/Call.js on lines 46..52
            src/hardware/instructions/Call.js on lines 54..60
            src/hardware/instructions/Call.js on lines 62..68
            src/hardware/instructions/Call.js on lines 70..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            operation[operation.CPE] = function (reg, l, h) {
    if (reg.PARITY === 1) {
        reg.PUSH(l * 0x100 + h);
    } else { 
        reg.PC += 3;
            Severity: Major
            Found in src/hardware/instructions/Call.js and 7 other locations - About 1 hr to fix
            src/hardware/instructions/Call.js on lines 14..20
            src/hardware/instructions/Call.js on lines 22..28
            src/hardware/instructions/Call.js on lines 30..36
            src/hardware/instructions/Call.js on lines 38..44
            src/hardware/instructions/Call.js on lines 46..52
            src/hardware/instructions/Call.js on lines 54..60
            src/hardware/instructions/Call.js on lines 62..68

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language