Sign upLogin

alexkappa/mustache

View on GitHub
Star

Showing 9 of 9 total issues

Function TestSimpleLookup has 86 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestSimpleLookup(t *testing.T) {
    for _, test := range []struct {
        context    interface{}
        assertions []struct {
            name  string
Severity: Major
Found in lookup_test.go - About 2 hrs to fix

    Function TestLexer has 64 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestLexer(t *testing.T) {
    for _, test := range []struct {
        template string
        expected []token
    }{
    Severity: Minor
    Found in lex_test.go - About 1 hr to fix

      Function lookup has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
      Open

      func lookup(name string, context ...interface{}) (interface{}, bool) {
    // If the dot notation was used we split the word in two and perform two
    // consecutive lookups. If the first one fails we return no value and a
    // negative truth. Taken from github.com/hoisie/mustache.
    if name != "." && strings.Contains(name, ".") {
      Severity: Minor
      Found in lookup.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function TestParser has 60 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func TestParser(t *testing.T) {
    for _, test := range []struct {
        template string
        expected []node
    }{
      Severity: Minor
      Found in parse_test.go - About 1 hr to fix

        Function lookup has 8 return statements (exceeds 4 allowed).
        Open

        func lookup(name string, context ...interface{}) (interface{}, bool) {
    // If the dot notation was used we split the word in two and perform two
    // consecutive lookups. If the first one fails we return no value and a
    // negative truth. Taken from github.com/hoisie/mustache.
    if name != "." && strings.Contains(name, ".") {
        Severity: Major
        Found in lookup.go - About 50 mins to fix

          Function testSpecFunc has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
          Open

          func testSpecFunc(t *testing.T, s Spec) func(t *testing.T) {
    return func(t *testing.T) {

        t.Parallel() // run each spec test concurrently.
          Severity: Minor
          Found in spec_test.go - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function stateTag has 5 return statements (exceeds 4 allowed).
          Open

          func stateTag(l *lexer) stateFn {
    if strings.HasPrefix(l.input[l.pos:], "}"+l.rightDelim) {
        l.seek(1)
        l.emit(tokenRawEnd)
        return stateRightDelim
          Severity: Major
          Found in lex.go - About 35 mins to fix

            Method parser.parseSection has 5 return statements (exceeds 4 allowed).
            Open

            func (p *parser) parseSection(inverse bool) (node, error) {
    t := p.read()
    if t.typ != tokenIdentifier {
        return nil, p.errorf(t, "unexpected token %s", t)
    }
            Severity: Major
            Found in parse.go - About 35 mins to fix

              Your code does not pass gofmt in 1 place. Go fmt your code!
              Open

              // Copyright (c) 2014 Alex Kalyvitis
              Severity: Minor
              Found in doc.go by gofmt
              Severity
              Category
              Status
              Source
              Language