Sign upLogin

alexlangberg/hapi-goldwasher

View on GitHub
Star

Showing 15 of 15 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('can reply with xml', function(done) {
    var url = urlWithParameters({
      url: 'http://google.com',
      output: 'xml'
    });
Severity: Major
Found in test/hapi-goldwasher.spec.js and 2 other locations - About 3 hrs to fix
test/hapi-goldwasher.spec.js on lines 118..129
test/hapi-goldwasher.spec.js on lines 131..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('can reply with atom', function(done) {
    var url = urlWithParameters({
      url: 'http://google.com',
      output: 'atom'
    });
Severity: Major
Found in test/hapi-goldwasher.spec.js and 2 other locations - About 3 hrs to fix
test/hapi-goldwasher.spec.js on lines 105..116
test/hapi-goldwasher.spec.js on lines 131..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('can reply with rss', function(done) {
    var url = urlWithParameters({
      url: 'http://google.com',
      output: 'rss'
    });
Severity: Major
Found in test/hapi-goldwasher.spec.js and 2 other locations - About 3 hrs to fix
test/hapi-goldwasher.spec.js on lines 105..116
test/hapi-goldwasher.spec.js on lines 118..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('can request with url parameter', function(done) {
    var url = urlWithParameters({ url: 'http://google.com'});

    server.inject({method: 'GET', url: url}, function(response) {
      response.statusCode.should.equal(200);
Severity: Major
Found in test/hapi-goldwasher.spec.js and 2 other locations - About 2 hrs to fix
test/hapi-goldwasher.spec.js on lines 172..179
test/hapi-goldwasher.spec.js on lines 181..188

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('can can handle too many redirects', function(done) {
    var url = urlWithParameters({ url: 'http://google.com'});

    server.inject({method: 'GET', url: url}, function(response) {
      response.statusCode.should.equal(404);
Severity: Major
Found in test/hapi-goldwasher.spec.js and 2 other locations - About 2 hrs to fix
test/hapi-goldwasher.spec.js on lines 78..85
test/hapi-goldwasher.spec.js on lines 172..179

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('can can handle invalid url', function(done) {
    var url = urlWithParameters({ url: 'foo'});

    server.inject({method: 'GET', url: url}, function(response) {
      response.statusCode.should.equal(404);
Severity: Major
Found in test/hapi-goldwasher.spec.js and 2 other locations - About 2 hrs to fix
test/hapi-goldwasher.spec.js on lines 78..85
test/hapi-goldwasher.spec.js on lines 181..188

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function register has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.register = function(server, options, next) {

  options = getOptions(options);

  server.route({
Severity: Minor
Found in lib/hapi-goldwasher.js - About 1 hr to fix

    Function register has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.register = function(server, options, next) {

  options = getOptions(options);

  server.route({
    Severity: Minor
    Found in lib/hapi-goldwasher.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getResponse has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var getResponse = function(server, options, request, callback) {
  var needleOptions = {
    follow_max: options.maxRedirects
  };
    Severity: Minor
    Found in lib/hapi-goldwasher.js - About 1 hr to fix

      Function getDefaultResponse has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var getDefaultResponse = function(server, options) {
  var text = {
    commaSeparated: ' (comma-separated for multiple,' +
    ' remember url encoding)',
    locale: ' (filter common stop words by language, "en" available)'
      Severity: Minor
      Found in lib/hapi-goldwasher.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if (request.query.output === 'rss') {
          return reply(result)
            .type('application/rss+xml')
            .header(options.header, goldwasherPack.version);
        }
        Severity: Major
        Found in lib/hapi-goldwasher.js and 2 other locations - About 50 mins to fix
        lib/hapi-goldwasher.js on lines 205..209
        lib/hapi-goldwasher.js on lines 211..215

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if (request.query.output === 'atom') {
          return reply(result)
            .type('application/atom+xml')
            .header(options.header, goldwasherPack.version);
        }
        Severity: Major
        Found in lib/hapi-goldwasher.js and 2 other locations - About 50 mins to fix
        lib/hapi-goldwasher.js on lines 205..209
        lib/hapi-goldwasher.js on lines 217..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if (request.query.output === 'xml') {
          return reply(result)
            .type('text/xml')
            .header(options.header, goldwasherPack.version);
        }
        Severity: Major
        Found in lib/hapi-goldwasher.js and 2 other locations - About 50 mins to fix
        lib/hapi-goldwasher.js on lines 211..215
        lib/hapi-goldwasher.js on lines 217..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                return reply(result)
          .header(options.header, goldwasherPack.version);
        Severity: Major
        Found in lib/hapi-goldwasher.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return callback(null, result);
          Severity: Major
          Found in lib/hapi-goldwasher.js - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language