Sign upLogin

alexlangberg/node-goldwasher-needle

View on GitHub
Star

Showing 10 of 10 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    gn(url, function(error, result, response) {
      should.not.exist(error);
      response.statusCode.should.equal(200);
      result.should.be.an('array');
      result.length.should.be.greaterThan(0);
Severity: Major
Found in test/goldwasher-needle.spec.js and 2 other locations - About 4 hrs to fix
test/goldwasher-needle.spec.js on lines 118..125
test/goldwasher-needle.spec.js on lines 150..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    gn(serverUrl + '/fulldocument', options, function(error, result, response) {
      should.not.exist(error);
      response.statusCode.should.equal(200);
      result.should.be.an('array');
      result.length.should.be.greaterThan(0);
Severity: Major
Found in test/goldwasher-needle.spec.js and 2 other locations - About 4 hrs to fix
test/goldwasher-needle.spec.js on lines 101..108
test/goldwasher-needle.spec.js on lines 118..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    gn(url, options, function(error, result, response) {
      should.not.exist(error);
      response.statusCode.should.equal(200);
      result.should.be.an('array');
      result.length.should.be.greaterThan(0);
Severity: Major
Found in test/goldwasher-needle.spec.js and 2 other locations - About 4 hrs to fix
test/goldwasher-needle.spec.js on lines 101..108
test/goldwasher-needle.spec.js on lines 150..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function run has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

var run = function(url, options, callback) {
  needle.get(url, options.needle, function(error, response, body) {
    var result;

    if (error) {
Severity: Minor
Found in lib/goldwasher-needle.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function run has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var run = function(url, options, callback) {
  needle.get(url, options.needle, function(error, response, body) {
    var result;

    if (error) {
Severity: Minor
Found in lib/goldwasher-needle.js - About 1 hr to fix

    Function getDefaults has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var getDefaults = function(url, options) {
  var defaults = {
    goldwasher: {
      url: url
    },
    Severity: Minor
    Found in lib/goldwasher-needle.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return callback(
          new Error('onlyFullDocument: not full document'),
          null,
          response
        );
      Severity: Major
      Found in lib/goldwasher-needle.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return callback(null, result, response, body);
        Severity: Major
        Found in lib/goldwasher-needle.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return callback(error);
          Severity: Major
          Found in lib/goldwasher-needle.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return callback(null, body, response);
            Severity: Major
            Found in lib/goldwasher-needle.js - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language