alexpeattie/nitlink

View on GitHub

Showing 119 of 119 total issues

Assignment Branch Condition size for metadata is too high. [83.49/15]
Open

    def metadata(response)
      response_class = response.class.name

      uri, status, (link, content_location) = case response_class
      when 'Curl::Easy'
Severity: Minor
Found in lib/nitlink/response_normalizer.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [40/10]
Open

    def metadata(response)
      response_class = response.class.name

      uri, status, (link, content_location) = case response_class
      when 'Curl::Easy'
Severity: Minor
Found in lib/nitlink/response_normalizer.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for metadata is too high. [18/6]
Open

    def metadata(response)
      response_class = response.class.name

      uri, status, (link, content_location) = case response_class
      when 'Curl::Easy'
Severity: Minor
Found in lib/nitlink/response_normalizer.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Assignment Branch Condition size for split_on_unquoted is too high. [24.1/15]
Open

    def split_on_unquoted(seperator)
      # 0 = start of string
      split_positions, ignored_split_positions = [0], [] 
      in_quote = false

Severity: Minor
Found in lib/nitlink/splitter.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [17/10]
Open

    def split_on_unquoted(seperator)
      # 0 = start of string
      split_positions, ignored_split_positions = [0], [] 
      in_quote = false

Severity: Minor
Found in lib/nitlink/splitter.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method split_on_unquoted has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def split_on_unquoted(seperator)
      # 0 = start of string
      split_positions, ignored_split_positions = [0], [] 
      in_quote = false

Severity: Minor
Found in lib/nitlink/splitter.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for split_on_unquoted is too high. [11/6]
Open

    def split_on_unquoted(seperator)
      # 0 = start of string
      split_positions, ignored_split_positions = [0], [] 
      in_quote = false

Severity: Minor
Found in lib/nitlink/splitter.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for split_on_unquoted is too high. [11/7]
Open

    def split_on_unquoted(seperator)
      # 0 = start of string
      split_positions, ignored_split_positions = [0], [] 
      in_quote = false

Severity: Minor
Found in lib/nitlink/splitter.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Perceived complexity for metadata is too high. [10/7]
Open

    def metadata(response)
      response_class = response.class.name

      uri, status, (link, content_location) = case response_class
      when 'Curl::Easy'
Severity: Minor
Found in lib/nitlink/response_normalizer.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method has too many lines. [12/10]
Open

    def extract_target_attributes(link_parameters)
      target_attributes = []
      link_parameters.each do |param_name, param_value|
        next if %(rel anchor).include?(param_name)
        next if %(media title title* type).include?(param_name) && first_match(target_attributes, param_name)
Severity: Minor
Found in lib/nitlink/parser.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

    def format(raw_params)
      raw_params.map do |raw_param_name, raw_param_value|
        next if !raw_param_name
        param_name = rstrip_ows(raw_param_name.downcase)

Severity: Minor
Found in lib/nitlink/param_extractor.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method metadata has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def metadata(response)
      response_class = response.class.name

      uri, status, (link, content_location) = case response_class
      when 'Curl::Easy'
Severity: Minor
Found in lib/nitlink/response_normalizer.rb - About 1 hr to fix

    Method metadata has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def metadata(response)
          response_class = response.class.name
    
          uri, status, (link, content_location) = case response_class
          when 'Curl::Easy'
    Severity: Minor
    Found in lib/nitlink/response_normalizer.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method extract_target_attributes has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def extract_target_attributes(link_parameters)
          target_attributes = []
          link_parameters.each do |param_name, param_value|
            next if %(rel anchor).include?(param_name)
            next if %(media title title* type).include?(param_name) && first_match(target_attributes, param_name)
    Severity: Minor
    Found in lib/nitlink/parser.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method format has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def format(raw_params)
          raw_params.map do |raw_param_name, raw_param_value|
            next if !raw_param_name
            param_name = rstrip_ows(raw_param_name.downcase)
    
    
    Severity: Minor
    Found in lib/nitlink/param_extractor.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing top-level module documentation comment.
    Open

    module Nitlink
    Severity: Minor
    Found in lib/nitlink.rb by rubocop

    This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

    The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

    Example:

    # bad
    class Person
      # ...
    end
    
    # good
    # Description/Explanation of Person class
    class Person
      # ...
    end

    Line is too long. [106/80]
    Open

          raise ArgumentError.new('relation_type cannot be blank') if (!relation_type || relation_type.empty?)
    Severity: Minor
    Found in lib/nitlink/link_collection.rb by rubocop

    Line is too long. [158/80]
    Open

          EncodedParamSyntaxError.new(%Q{Syntax error decoding encoded parameter value "#{ val }", must be in the form: charset "'" [ language ] "'" value-chars})
    Severity: Minor
    Found in lib/nitlink/param_decoder.rb by rubocop

    Line is too long. [88/80]
    Open

          [URI.parse(uri.to_s), (status ? Integer(status) : status), link, content_location]
    Severity: Minor
    Found in lib/nitlink/response_normalizer.rb by rubocop

    Use only ascii symbols in comments.
    Open

            # ↑ returned by OpenURI
    Severity: Minor
    Found in lib/nitlink/response_normalizer.rb by rubocop

    This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

    Example:

    # bad
    # Translates from English to 日本語。
    
    # good
    # Translates from English to Japanese
    Severity
    Category
    Status
    Source
    Language