Sign upLogin

alexrothenberg/motion-addressbook

View on GitHub
Star
motion/address_book.rb

Summary

Maintainability
A
50 mins
Test Coverage

Method request_authorization has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def request_authorization(&block)
    synchronous = !block
    access_callback = lambda { |granted, error|
      # not sure what to do with error ... so we're ignoring it
      @address_book_access_granted = granted
Severity: Minor
Found in motion/address_book.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ios6_create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def ios6_create
    error = nil
    if authorized?
      @address_book = ABAddressBookCreateWithOptions(nil, error)
    else
Severity: Minor
Found in motion/address_book.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status