Sign upLogin

alexrothenberg/motion-addressbook

View on GitHub
Star
motion/address_book/ios/person.rb

Summary

Maintainability
D
2 days
Test Coverage

Class Person has 69 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Person
    attr_reader :error
    attr_reader :address_book

    def initialize(attributes = nil, existing_ab_person = nil, opts = {})
Severity: Major
Found in motion/address_book/ios/person.rb - About 1 day to fix

    File person.rb has 379 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module AddressBook
  class Person
    attr_reader :error
    attr_reader :address_book
    Severity: Minor
    Found in motion/address_book/ios/person.rb - About 5 hrs to fix

      Method load_ab_person has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def load_ab_person
      @attributes ||= {}

      Person.single_value_property_map.each do |ab_property, attr_key|
        if attributes[attr_key]
      Severity: Minor
      Found in motion/address_book/ios/person.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status