Sign upLogin

alexrothenberg/motion-addressbook

View on GitHub
Star
motion/address_book/osx/person.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Person has 47 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Person
    attr_reader :error
    attr_reader :address_book

    def initialize(target, opts = {})
Severity: Minor
Found in motion/address_book/osx/person.rb - About 6 hrs to fix

    Method load_ab_person has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def load_ab_person
      @attributes ||= {}

      SingleValuePropertyMap.each do |ab_property, attr_key|
        if attributes[attr_key]
    Severity: Minor
    Found in motion/address_book/osx/person.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method import_ab_person has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def import_ab_person
      @attributes = {}
      @modification_date = nil

      SingleValuePropertyMap.each do |ab_property, attr_key|
    Severity: Minor
    Found in motion/address_book/osx/person.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status