Showing 5 of 5 total issues
Method take
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def take(limit = nil)
if limit && limit > 1
result = super(limit)
result.size > 1 ? result : Array.new(limit) { null_object }
else
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Add an empty line after magic comments. Open
Open
lib = File.expand_path("../lib", __FILE__)
- Read upRead up
- Exclude checks
Checks for a newline after the final magic comment.
Example:
# good
# frozen_string_literal: true
# Some documentation for Person
class Person
# Some code
end
# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
# Some code
end
FIXME found Open
Open
(TODO, FIXME, OPTIMIZE, HACK, REVIEW).
- Exclude checks
TODO found Open
Open
(TODO, FIXME, OPTIMIZE, HACK, REVIEW).
- Exclude checks
HACK found Open
Open
(TODO, FIXME, OPTIMIZE, HACK, REVIEW).
- Exclude checks