Sign upLogin

algb12/GraphDS

View on GitHub
Star
src/Persistence/ExportGraph.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method getGraphML has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getGraphML()
    {
        $directionality = $this->graph->directed ? 'directed' : 'undirected';
        $export = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8"?>'
                                      .'<graphml xmlns="http://graphml.graphdrawing.org/xmlns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://graphml.graphdrawing.org/xmlns http://graphml.graphdrawing.org/xmlns/1.0/graphml.xsd">'
Severity: Minor
Found in src/Persistence/ExportGraph.php - About 1 hr to fix

    Function getGraphML has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getGraphML()
    {
        $directionality = $this->graph->directed ? 'directed' : 'undirected';
        $export = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8"?>'
                                      .'<graphml xmlns="http://graphml.graphdrawing.org/xmlns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://graphml.graphdrawing.org/xmlns http://graphml.graphdrawing.org/xmlns/1.0/graphml.xsd">'
    Severity: Minor
    Found in src/Persistence/ExportGraph.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid assigning values to variables in if clauses and the like (line '74', column '27').
    Open

        public function getGraphML()
    {
        $directionality = $this->graph->directed ? 'directed' : 'undirected';
        $export = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8"?>'
                                      .'<graphml xmlns="http://graphml.graphdrawing.org/xmlns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://graphml.graphdrawing.org/xmlns http://graphml.graphdrawing.org/xmlns/1.0/graphml.xsd">'
    Severity: Minor
    Found in src/Persistence/ExportGraph.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid assigning values to variables in if clauses and the like (line '84', column '31').
    Open

        public function getGraphML()
    {
        $directionality = $this->graph->directed ? 'directed' : 'undirected';
        $export = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8"?>'
                                      .'<graphml xmlns="http://graphml.graphdrawing.org/xmlns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://graphml.graphdrawing.org/xmlns http://graphml.graphdrawing.org/xmlns/1.0/graphml.xsd">'
    Severity: Minor
    Found in src/Persistence/ExportGraph.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    There are no issues that match your filters.

    Category
    Status