Sign upLogin

algolia/algoliasearch-client-ruby

View on GitHub
Star

Showing 40 of 40 total issues

Class Index has 65 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Index
      include CallType
      include Helpers

      attr_reader :name, :transporter, :config, :logger
Severity: Major
Found in lib/algolia/search_index.rb - About 1 day to fix

    Class Client has 56 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Client
      include CallType
      include Helpers

      # Initialize a client to connect to Algolia
    Severity: Major
    Found in lib/algolia/search_client.rb - About 1 day to fix

      File search_index.rb has 454 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      module Algolia
  module Search
    # Class Index
    class Index
      include CallType
      Severity: Minor
      Found in lib/algolia/search_index.rb - About 6 hrs to fix

        File search_client.rb has 283 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'faraday'
require 'openssl'
require 'base64'

module Algolia
        Severity: Minor
        Found in lib/algolia/search_client.rb - About 2 hrs to fix

          Method send_request has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

                def send_request(host, method, path, body, headers, timeout, connect_timeout)
        connection                      = connection(host)
        connection.options.timeout      = timeout
        connection.options.open_timeout = connect_timeout
          Severity: Minor
          Found in lib/algolia/http/http_requester.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method save_synonyms has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def save_synonyms(synonyms, opts = {})
        if synonyms.is_a?(SynonymIterator)
          iterated = []
          synonyms.each do |synonym|
            iterated.push(synonym)
          Severity: Minor
          Found in lib/algolia/search_index.rb - About 1 hr to fix

            Method find_object has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                  def find_object(callback, opts = {})
        request_options = symbolize_hash(opts)
        paginate        = true
        page            = 0
            Severity: Minor
            Found in lib/algolia/search_index.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method each has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                def each
      loop do
        data = {}

        if @response
            Severity: Minor
            Found in lib/algolia/iterators/object_iterator.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method send_request has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def send_request(host, method, path, body, headers, timeout, connect_timeout)
        connection                      = connection(host)
        connection.options.timeout      = timeout
        connection.options.open_timeout = connect_timeout
            Severity: Minor
            Found in lib/algolia/http/http_requester.rb - About 1 hr to fix

              Method save_rules has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def save_rules(rules, opts = {})
        if rules.is_a?(RuleIterator)
          iterated = []
          rules.each do |rule|
            iterated.push(rule)
              Severity: Minor
              Found in lib/algolia/search_index.rb - About 1 hr to fix

                Method deserialize_settings has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                  def deserialize_settings(data, symbolize_keys)
    settings = data
    keys     = {
      attributesToIndex: 'searchableAttributes',
      numericAttributesToIndex: 'numericAttributesForFiltering',
                Severity: Minor
                Found in lib/algolia/helpers.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method request has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                      def request(call_type, method, path, body = {}, opts = {})
        @retry_strategy.get_tryable_hosts(call_type).each do |host|
          opts[:timeout]         ||= get_timeout(call_type) * (host.retry_count + 1)
          opts[:connect_timeout] ||= @config.connect_timeout * (host.retry_count + 1)
                Severity: Minor
                Found in lib/algolia/transport/transport.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method get_tryable_hosts has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                      def get_tryable_hosts(call_type)
        @lock.synchronize do
          reset_expired_hosts

          if @hosts.any? { |host| host.up && flag?(host.accept, call_type) }
                Severity: Minor
                Found in lib/algolia/transport/retry_strategy.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method each has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    def each
      loop do
        if @response
          parsed_response = symbolize_hash(@response)
          parsed_data     = symbolize_hash(@data)
                Severity: Minor
                Found in lib/algolia/iterators/paginator_iterator.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method send_request has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def send_request(host, method, path, body, headers, timeout, connect_timeout)
                Severity: Major
                Found in lib/algolia/http/http_requester.rb - About 50 mins to fix

                  Method clicked_object_ids_after_search has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def clicked_object_ids_after_search(event_name, index_name,
        object_ids, positions, query_id, opts = {})
                  Severity: Minor
                  Found in lib/algolia/insights_client.rb - About 45 mins to fix

                    Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def initialize(opts = {})
      raise AlgoliaError, 'No Application ID provided, please set :application_id' unless opts.has_key?(:application_id)
      raise AlgoliaError, 'No API key provided, please set :api_key' unless opts.has_key?(:api_key)

      @app_id  = opts[:application_id]
                    Severity: Minor
                    Found in lib/algolia/config/base_config.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def delete_rule(object_id, opts = {})
        forward_to_replicas = false
        request_options     = symbolize_hash(opts)

        if request_options[:forwardToReplicas]
                    Severity: Minor
                    Found in lib/algolia/search_index.rb and 1 other location - About 40 mins to fix
                    lib/algolia/search_index.rb on lines 733..748

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 38.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def delete_synonym(object_id, opts = {})
        forward_to_replicas = false
        request_options     = symbolize_hash(opts)

        if request_options[:forwardToReplicas]
                    Severity: Minor
                    Found in lib/algolia/search_index.rb and 1 other location - About 40 mins to fix
                    lib/algolia/search_index.rb on lines 560..576

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 38.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def clear_rules(opts = {})
        forward_to_replicas = false
        request_options     = symbolize_hash(opts)

        if request_options[:forwardToReplicas]
                    Severity: Minor
                    Found in lib/algolia/search_index.rb and 1 other location - About 40 mins to fix
                    lib/algolia/search_index.rb on lines 698..713

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 37.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language