alibaba/kt-connect

View on GitHub

Showing 79 of 109 total issues

Function combineKubeOpts has 7 return statements (exceeds 4 allowed).
Open

func combineKubeOpts() (err error) {
    var config *clientcmdapi.Config
    if opt.Get().Global.Kubeconfig != ""{
        // if kubeconfig specified, always read from it
        _ = os.Setenv(util.EnvKubeConfig, opt.Get().Global.Kubeconfig)
Severity: Major
Found in pkg/kt/command/general/setup.go - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

            } else if util.IsMacos() {
                dnsPort = opt.Get().Connect.DnsPort
            }
    Severity: Major
    Found in pkg/kt/command/connect/common.go - About 45 mins to fix

      Function createRouter has 7 return statements (exceeds 4 allowed).
      Open

      func createRouter(routerPodName string, svcName string, ports map[int]int, labels map[string]string, versionMark string) error {
          namespace := opt.Get().Global.Namespace
          routerPod, err := cluster.Ins().GetPod(routerPodName, namespace)
          if err == nil && routerPod.DeletionTimestamp != nil {
              routerPod, err = cluster.Ins().WaitPodTerminate(routerPodName, namespace)
      Severity: Major
      Found in pkg/kt/command/mesh/auto.go - About 45 mins to fix

        Function AutoMesh has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
        Open

        func AutoMesh(svc *coreV1.Service) error {
            // Lock service to avoid conflict, must be first step
            svc, err := general.LockService(svc.Name, opt.Get().Global.Namespace, 0)
            if err != nil {
                return err
        Severity: Minor
        Found in pkg/kt/command/mesh/auto.go - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                        if keepShortDomain {
                            recordsToKeep = append(recordsToKeep, l)
                        }
        Severity: Major
        Found in pkg/kt/service/dns/hosts.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if _, err = strconv.Atoi(upstreamParts[1]); err == nil {
                                  dnsAddresses = append(dnsAddresses, fmt.Sprintf("udp:%s:%s", upstreamDns, upstreamParts[1]))
                              } else {
                                  dnsAddresses = append(dnsAddresses, fmt.Sprintf("%s:%s:%d", upstreamParts[0], upstreamDns, common.StandardDnsPort))
                              }
          Severity: Major
          Found in pkg/kt/service/dns/dnsserver.go - About 45 mins to fix

            Function SaveProfile has 6 return statements (exceeds 4 allowed).
            Open

            func SaveProfile(args []string) error {
                if len(args) != 1 {
                    return fmt.Errorf("must specifiy a profile name")
                }
                profile := profileFile(args[0])
            Severity: Major
            Found in pkg/kt/command/config/save.go - About 40 mins to fix

              Function Mesh has 6 return statements (exceeds 4 allowed).
              Open

              func Mesh(resourceName string) error {
                  ch, err := general.SetupProcess(util.ComponentMesh)
                  if err != nil {
                      return err
                  }
              Severity: Major
              Found in pkg/kt/command/mesh.go - About 40 mins to fix

                Function Show has 6 return statements (exceeds 4 allowed).
                Open

                func Show(args []string) error {
                    if len(args) > 0 {
                        return fmt.Errorf("parameter '%s' is invalid", args[0])
                    }
                    customConfig := loadCustomConfig()
                Severity: Major
                Found in pkg/kt/command/config/show.go - About 40 mins to fix

                  Function parsePort has 6 return statements (exceeds 4 allowed).
                  Open

                  func parsePort(args []string) (localPort int, remotePort int, err error) {
                      if len(args) < 2 {
                          // port not specified
                          return -1, -1, nil
                      } else if count := strings.Count(args[1], ":"); count == 0 {
                  Severity: Major
                  Found in pkg/kt/command/forward.go - About 40 mins to fix

                    Function NewForwardCommand has 6 return statements (exceeds 4 allowed).
                    Open

                    func NewForwardCommand() *cobra.Command {
                        cmd := &cobra.Command{
                            Use:   "forward",
                            Short: "Redirect local port to a service or any remote address",
                            PreRunE: func(cmd *cobra.Command, args []string) error {
                    Severity: Major
                    Found in pkg/kt/command/forward.go - About 40 mins to fix

                      Function GetServiceByResourceName has 6 return statements (exceeds 4 allowed).
                      Open

                      func GetServiceByResourceName(resourceName, namespace string) (*coreV1.Service, error) {
                          resourceType, name, err := ParseResourceName(resourceName)
                          if err != nil {
                              return nil, err
                          }
                      Severity: Major
                      Found in pkg/kt/command/general/resource.go - About 40 mins to fix

                        Function GetDeploymentByResourceName has 6 return statements (exceeds 4 allowed).
                        Open

                        func GetDeploymentByResourceName(resourceName, namespace string) (*appV1.Deployment, error) {
                            resourceType, name, err := ParseResourceName(resourceName)
                            if err != nil {
                                return nil, err
                            }
                        Severity: Major
                        Found in pkg/kt/command/general/resource.go - About 40 mins to fix

                          Function createRouter has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          func createRouter(routerPodName string, svcName string, ports map[int]int, labels map[string]string, versionMark string) error {
                          Severity: Minor
                          Found in pkg/kt/command/mesh/auto.go - About 35 mins to fix

                            Function Forward has 5 return statements (exceeds 4 allowed).
                            Open

                            func Forward(args []string) error {
                                ch, err := general.SetupProcess(util.ComponentForward)
                                if err != nil {
                                    return err
                                }
                            Severity: Major
                            Found in pkg/kt/command/forward.go - About 35 mins to fix

                              Method Kubernetes.GetKtResources has 5 return statements (exceeds 4 allowed).
                              Open

                              func (k *Kubernetes) GetKtResources(namespace string) ([]coreV1.Pod, []coreV1.ConfigMap, []appV1.Deployment, []coreV1.Service, error) {
                                  pods, err := Ins().GetPodsByLabel(map[string]string{util.ControlBy: util.KubernetesToolkit}, namespace)
                                  if err != nil {
                                      return nil, nil, nil, nil, err
                                  }
                              Severity: Major
                              Found in pkg/kt/service/cluster/global.go - About 35 mins to fix

                                Function NewRecoverCommand has 5 return statements (exceeds 4 allowed).
                                Open

                                func NewRecoverCommand() *cobra.Command {
                                    cmd := &cobra.Command{
                                        Use:  "recover",
                                        Short: "Restore traffic of specified kubernetes service changed by exchange or mesh",
                                        PreRunE: func(cmd *cobra.Command, args []string) error {
                                Severity: Major
                                Found in pkg/kt/command/recover.go - About 35 mins to fix

                                  Method Kubernetes.createAndGetPod has 5 return statements (exceeds 4 allowed).
                                  Open

                                  func (k *Kubernetes) createAndGetPod(metaAndSpec *PodMetaAndSpec, sshcm string) (*coreV1.Pod, error) {
                                      if opt.Get().Global.UseShadowDeployment {
                                          if err := k.createShadowDeployment(metaAndSpec, sshcm); err != nil {
                                              return nil, err
                                          }
                                  Severity: Major
                                  Found in pkg/kt/service/cluster/shadow_pod.go - About 35 mins to fix

                                    Function NewMeshCommand has 5 return statements (exceeds 4 allowed).
                                    Open

                                    func NewMeshCommand() *cobra.Command {
                                        cmd := &cobra.Command{
                                            Use:  "mesh",
                                            Short: "Redirect marked requests of specified kubernetes service to local",
                                            PreRunE: func(cmd *cobra.Command, args []string) error {
                                    Severity: Major
                                    Found in pkg/kt/command/mesh.go - About 35 mins to fix

                                      Function NewConnectCommand has 5 return statements (exceeds 4 allowed).
                                      Open

                                      func NewConnectCommand() *cobra.Command {
                                          cmd := &cobra.Command{
                                              Use:  "connect",
                                              Short: "Create a network tunnel to kubernetes cluster",
                                              PreRunE: func(cmd *cobra.Command, args []string) error {
                                      Severity: Major
                                      Found in pkg/kt/command/connect.go - About 35 mins to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language