Sign upLogin

alibaba/kt-connect

View on GitHub
Star
pkg/kt/command/forward/common.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function getPodNameAndPort has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func getPodNameAndPort(serviceName string, remotePort int, namespace string) (string, int, int, error) {
    svc, err := cluster.Ins().GetService(serviceName, namespace)
    if err != nil {
        if k8sErrors.IsNotFound(err) {
            return "", 0, 0, fmt.Errorf("service '%s' is not found in namespace %s", serviceName, namespace)
Severity: Minor
Found in pkg/kt/command/forward/common.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getPodNameAndPort has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func getPodNameAndPort(serviceName string, remotePort int, namespace string) (string, int, int, error) {
    svc, err := cluster.Ins().GetService(serviceName, namespace)
    if err != nil {
        if k8sErrors.IsNotFound(err) {
            return "", 0, 0, fmt.Errorf("service '%s' is not found in namespace %s", serviceName, namespace)
Severity: Minor
Found in pkg/kt/command/forward/common.go - About 1 hr to fix

    Function getPodNameAndPort has 9 return statements (exceeds 4 allowed).
    Open

    func getPodNameAndPort(serviceName string, remotePort int, namespace string) (string, int, int, error) {
    svc, err := cluster.Ins().GetService(serviceName, namespace)
    if err != nil {
        if k8sErrors.IsNotFound(err) {
            return "", 0, 0, fmt.Errorf("service '%s' is not found in namespace %s", serviceName, namespace)
    Severity: Major
    Found in pkg/kt/command/forward/common.go - About 55 mins to fix

      There are no issues that match your filters.

      Category
      Status