Sign upLogin

alibaba/kt-connect

View on GitHub
Star
pkg/kt/command/general/resource.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function UpdateServiceSelector has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
Open

func UpdateServiceSelector(svcName, namespace string, selector map[string]string) error {
    svc, err := cluster.Ins().GetService(svcName, namespace)
    if err != nil {
        return err
    }
Severity: Minor
Found in pkg/kt/command/general/resource.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function UpdateServiceSelector has 54 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func UpdateServiceSelector(svcName, namespace string, selector map[string]string) error {
    svc, err := cluster.Ins().GetService(svcName, namespace)
    if err != nil {
        return err
    }
Severity: Minor
Found in pkg/kt/command/general/resource.go - About 1 hr to fix

    Function GetTargetPorts has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
    Open

    func GetTargetPorts(svc *coreV1.Service) map[int]string {
    var pod *coreV1.Pod = nil
    svcPorts := svc.Spec.Ports
    targetPorts := map[int]string{}
    for _, p := range svcPorts {
    Severity: Minor
    Found in pkg/kt/command/general/resource.go - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function UpdateServiceSelector has 8 return statements (exceeds 4 allowed).
    Open

    func UpdateServiceSelector(svcName, namespace string, selector map[string]string) error {
    svc, err := cluster.Ins().GetService(svcName, namespace)
    if err != nil {
        return err
    }
    Severity: Major
    Found in pkg/kt/command/general/resource.go - About 50 mins to fix

      Function GetServiceByResourceName has 6 return statements (exceeds 4 allowed).
      Open

      func GetServiceByResourceName(resourceName, namespace string) (*coreV1.Service, error) {
    resourceType, name, err := ParseResourceName(resourceName)
    if err != nil {
        return nil, err
    }
      Severity: Major
      Found in pkg/kt/command/general/resource.go - About 40 mins to fix

        Function GetDeploymentByResourceName has 6 return statements (exceeds 4 allowed).
        Open

        func GetDeploymentByResourceName(resourceName, namespace string) (*appV1.Deployment, error) {
    resourceType, name, err := ParseResourceName(resourceName)
    if err != nil {
        return nil, err
    }
        Severity: Major
        Found in pkg/kt/command/general/resource.go - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if err == nil && len(podList.Items) > 0 && podList.Items[0].Annotations != nil && podList.Items[0].Annotations[util.KtUser] != "" {
        return " (" + podList.Items[0].Annotations[util.KtUser] + ")"
    }
          Severity: Minor
          Found in pkg/kt/command/general/resource.go and 1 other location - About 35 mins to fix
          pkg/kt/command/general/resource.go on lines 251..253

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if err == nil && len(appList.Items) > 0 && appList.Items[0].Annotations != nil && appList.Items[0].Annotations[util.KtUser] != "" {
        return " (" + appList.Items[0].Annotations[util.KtUser] + ")"
    }
          Severity: Minor
          Found in pkg/kt/command/general/resource.go and 1 other location - About 35 mins to fix
          pkg/kt/command/general/resource.go on lines 247..249

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status