Sign upLogin

alibaba/kt-connect

View on GitHub
Star
pkg/kt/command/mesh.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function Mesh has 6 return statements (exceeds 4 allowed).
Open

func Mesh(resourceName string) error {
    ch, err := general.SetupProcess(util.ComponentMesh)
    if err != nil {
        return err
    }
Severity: Major
Found in pkg/kt/command/mesh.go - About 40 mins to fix

    Function NewMeshCommand has 5 return statements (exceeds 4 allowed).
    Open

    func NewMeshCommand() *cobra.Command {
    cmd := &cobra.Command{
        Use:  "mesh",
        Short: "Redirect marked requests of specified kubernetes service to local",
        PreRunE: func(cmd *cobra.Command, args []string) error {
    Severity: Major
    Found in pkg/kt/command/mesh.go - About 35 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func NewMeshCommand() *cobra.Command {
    cmd := &cobra.Command{
        Use:  "mesh",
        Short: "Redirect marked requests of specified kubernetes service to local",
        PreRunE: func(cmd *cobra.Command, args []string) error {
      Severity: Major
      Found in pkg/kt/command/mesh.go and 2 other locations - About 3 hrs to fix
      pkg/kt/command/exchange.go on lines 15..36
      pkg/kt/command/preview.go on lines 16..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 268.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status