Sign upLogin

alibaba/kt-connect

View on GitHub
Star
pkg/kt/command/recover.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function Recover has 57 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func Recover(serviceName string) error {
    svc, err := cluster.Ins().GetService(serviceName, opt.Get().Global.Namespace)
    if err != nil {
        log.Error().Err(err).Msgf("Failed to fetch service '%s'", serviceName)
    }
Severity: Minor
Found in pkg/kt/command/recover.go - About 1 hr to fix

    Function Recover has 11 return statements (exceeds 4 allowed).
    Open

    func Recover(serviceName string) error {
    svc, err := cluster.Ins().GetService(serviceName, opt.Get().Global.Namespace)
    if err != nil {
        log.Error().Err(err).Msgf("Failed to fetch service '%s'", serviceName)
    }
    Severity: Major
    Found in pkg/kt/command/recover.go - About 1 hr to fix

      Function Recover has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

      func Recover(serviceName string) error {
    svc, err := cluster.Ins().GetService(serviceName, opt.Get().Global.Namespace)
    if err != nil {
        log.Error().Err(err).Msgf("Failed to fetch service '%s'", serviceName)
    }
      Severity: Minor
      Found in pkg/kt/command/recover.go - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function NewRecoverCommand has 5 return statements (exceeds 4 allowed).
      Open

      func NewRecoverCommand() *cobra.Command {
    cmd := &cobra.Command{
        Use:  "recover",
        Short: "Restore traffic of specified kubernetes service changed by exchange or mesh",
        PreRunE: func(cmd *cobra.Command, args []string) error {
      Severity: Major
      Found in pkg/kt/command/recover.go - About 35 mins to fix

        Function fetchTargetRole has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func fetchTargetRole(apps *appV1.DeploymentList, pods *coreV1.PodList) (*appV1.Deployment, *coreV1.Pod, string) {
    if len(apps.Items) > 0 {
        for _, app := range apps.Items {
            if app.Labels != nil {
                if role, ok2 := app.Labels[util.KtRole]; ok2 {
        Severity: Minor
        Found in pkg/kt/command/recover.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status