Sign upLogin

alibaba/transmittable-thread-local

View on GitHub
Star

Showing 208 of 208 total issues

Method afterReplay has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    Object afterReplay(Object data) {
        @SuppressWarnings("unchecked")
        Set<CrrTransmitCallback> callbacks = (Set<CrrTransmitCallback>) data;
        for (CrrTransmitCallback cb : callbacks) {
            try {
Severity: Minor
Found in ttl-core/src/main/java/com/alibaba/crr/composite/CompositeCrrTransmitCallback.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method splitCommaColonStringToKV has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @NonNull
    static Map<String, String> splitCommaColonStringToKV(@Nullable final String commaColonString) {
        final Map<String, String> ret = new HashMap<>();
        if (commaColonString == null || commaColonString.trim().length() == 0) return ret;
Severity: Minor
Found in ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/agent/TtlAgentHelper.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadExtensionInstances has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    static <T> Map<ClassLoader, Set<T>> loadExtensionInstances(
            ClassLoader classLoader, LinkedHashSet<String> instanceClassNames, Class<T> superType,
            String foundMsgHead, String failLoadMsgHead
    ) {
        Map<ClassLoader, Set<T>> ret = new HashMap<>();
Severity: Minor
Found in ttl-agent/src/main/java/com/alibaba/ttl3/agent/TtlExtensionTransformletManager.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method restore has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public void restore(@NonNull Backup backup) {
        final Snapshot snapshot = (Snapshot) backup;
        final Object data = callback.beforeRestore(snapshot.data);

        for (Map.Entry<CrrTransmit<Object, Object>, Object> entry : snapshot.crrTransmit2Value.entrySet()) {
Severity: Minor
Found in ttl-core/src/main/java/com/alibaba/crr/composite/CompositeCrrTransmit.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadExtensionInstances has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    static <T> Map<ClassLoader, Set<T>> loadExtensionInstances(
        ClassLoader classLoader, LinkedHashSet<String> instanceClassNames, Class<T> superType,
        String foundMsgHead, String failLoadMsgHead
    ) {
        Map<ClassLoader, Set<T>> ret = new HashMap<>();
Severity: Minor
Found in ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/agent/TtlExtensionTransformletManager.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @NonNull
    @ParametersAreNonnullByDefault
    @SuppressWarnings("ConstantConditions")
    public static <S> TransmittableThreadLocal<S> withInitialAndCopier(Supplier<? extends S> supplier, TtlCopier<S> copierForChildValueAndCopy) {
        if (supplier == null) throw new NullPointerException("supplier is null");
Severity: Minor
Found in ttl2-compatible/src/main/java/com/alibaba/ttl/TransmittableThreadLocal.java and 1 other location - About 35 mins to fix
ttl-core/src/main/java/com/alibaba/ttl3/TransmittableThreadLocal.java on lines 147..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @NonNull
    @ParametersAreNonnullByDefault
    @SuppressWarnings("ConstantConditions")
    public static <S> TransmittableThreadLocal<S> withInitialAndGenerator(Supplier<? extends S> supplier, UnaryOperator<S> generatorForChildValueAndTransmitteeValue) {
        if (supplier == null) throw new NullPointerException("supplier is null");
Severity: Minor
Found in ttl-core/src/main/java/com/alibaba/ttl3/TransmittableThreadLocal.java and 1 other location - About 35 mins to fix
ttl2-compatible/src/main/java/com/alibaba/ttl/TransmittableThreadLocal.java on lines 153..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

        if (!clazz.subclassOf(clazz.getClassPool().get(TIMER_TASK_CLASS_NAME))) return;
Severity: Major
Found in ttl-agent/src/main/java/com/alibaba/ttl3/agent/transformlet/internal/TimerTaskTtlTransformlet.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return nullSafeHashCode((double[]) obj);
    Severity: Major
    Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return lineNum + 1;
      Severity: Major
      Found in ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/agent/TtlExtensionTransformletManager.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return Arrays.equals((long[]) o1, (long[]) o2);
        Severity: Major
        Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return classInfo.getCtClass().toBytecode();
          Severity: Major
          Found in ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/agent/TtlTransformer.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return Arrays.equals((double[]) o1, (double[]) o2);
            Severity: Major
            Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return null;
              Severity: Major
              Found in ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/agent/transformlet/helper/TtlTransformletHelper.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return false;
                Severity: Major
                Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return Arrays.equals((float[]) o1, (float[]) o2);
                  Severity: Major
                  Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return nullSafeHashCode((int[]) obj);
                    Severity: Major
                    Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              if (!clazz.subclassOf(clazz.getClassPool().get(TIMER_TASK_CLASS_NAME))) return;
                      Severity: Major
                      Found in ttl2-compatible/src/main/java/com/alibaba/ttl/threadpool/agent/transformlet/internal/TimerTaskTtlTransformlet.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return Arrays.equals((int[]) o1, (int[]) o2);
                        Severity: Major
                        Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return obj.hashCode();
                          Severity: Major
                          Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language