Sign upLogin

alibaba/transmittable-thread-local

View on GitHub
Star
ttl2-compatible/src/main/java/com/alibaba/ttl/TtlTimerTask.java

Summary

Maintainability
A
2 hrs
Test Coverage

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    @Override
    public void run() {
        final Object captured = capturedRef.get();
        if (captured == null || releaseTtlValueReferenceAfterRun && !capturedRef.compareAndSet(captured, null)) {
            throw new IllegalStateException("TTL value reference is released after run!");
Severity: Major
Found in ttl2-compatible/src/main/java/com/alibaba/ttl/TtlTimerTask.java and 3 other locations - About 1 hr to fix
ttl-core/src/main/java/com/alibaba/ttl3/TtlRunnable.java on lines 52..65
ttl-core/src/main/java/com/alibaba/ttl3/TtlTimerTask.java on lines 52..65
ttl2-compatible/src/main/java/com/alibaba/ttl/TtlRunnable.java on lines 51..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    @NonNull
    public static List<TimerTask> unwraps(@Nullable Collection<? extends TimerTask> tasks) {
        if (tasks == null) return Collections.emptyList();

        List<TimerTask> copy = new ArrayList<>();
Severity: Major
Found in ttl2-compatible/src/main/java/com/alibaba/ttl/TtlTimerTask.java and 4 other locations - About 1 hr to fix
ttl-core/src/main/java/com/alibaba/ttl3/TtlCallable.java on lines 219..229
ttl-core/src/main/java/com/alibaba/ttl3/TtlRunnable.java on lines 217..227
ttl2-compatible/src/main/java/com/alibaba/ttl/TtlCallable.java on lines 236..246
ttl2-compatible/src/main/java/com/alibaba/ttl/TtlRunnable.java on lines 234..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    @Nullable
    @Contract(value = "null, _, _ -> null; !null, _, _ -> !null", pure = true)
    public static TtlTimerTask get(@Nullable TimerTask timerTask, boolean releaseTtlValueReferenceAfterRun, boolean idempotent) {
        if (timerTask == null) return null;
Severity: Major
Found in ttl2-compatible/src/main/java/com/alibaba/ttl/TtlTimerTask.java and 5 other locations - About 40 mins to fix
ttl-core/src/main/java/com/alibaba/ttl3/TtlCallable.java on lines 136..147
ttl-core/src/main/java/com/alibaba/ttl3/TtlRunnable.java on lines 129..140
ttl-core/src/main/java/com/alibaba/ttl3/TtlTimerTask.java on lines 136..147
ttl2-compatible/src/main/java/com/alibaba/ttl/TtlCallable.java on lines 151..162
ttl2-compatible/src/main/java/com/alibaba/ttl/TtlRunnable.java on lines 144..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status