Sign upLogin

alientronics/fleetany-alerts

View on GitHub
Star

Showing 13 of 13 total issues

The class AlertsTest has 13 public methods. Consider refactoring AlertsTest to keep number of public methods under 10.
Open

class AlertsTest extends TestCase
{
    use DatabaseTransactions;
    /**
     * Creates the application.
Severity: Minor
Found in tests/AlertsTest.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Method testAlertsPostSuccessAfterHours has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testAlertsPostSuccessAfterHours()
    {
        $emails = [];
        $names = [];
        $emails[] = "admin@alientronics.com.br";
Severity: Minor
Found in tests/AlertsTest.php - About 1 hr to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            $this->post('/api/v1/alert', ['api_token' => env('APP_TOKEN'),
                'emails' => json_encode($emails),
                'company_id' => 1,
                'names' => json_encode($names),
                'subject' => 'Teste Assunto Email',
    Severity: Major
    Found in tests/AlertsTest.php and 2 other locations - About 1 hr to fix
    tests/AlertsTest.php on lines 109..123
    tests/AlertsTest.php on lines 162..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            $this->post('/api/v1/alert', ['api_token' => env('APP_TOKEN'),
                'emails' => json_encode($emails),
                'company_id' => 1,
                'names' => json_encode($names),
                'subject' => 'Teste Assunto Email',
    Severity: Major
    Found in tests/AlertsTest.php and 2 other locations - About 1 hr to fix
    tests/AlertsTest.php on lines 136..150
    tests/AlertsTest.php on lines 162..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            $this->post('/api/v1/alert', ['api_token' => env('APP_TOKEN'),
                'emails' => json_encode($emails),
                'company_id' => 1,
                'names' => json_encode($names),
                'subject' => 'Teste Assunto Email',
    Severity: Major
    Found in tests/AlertsTest.php and 2 other locations - About 1 hr to fix
    tests/AlertsTest.php on lines 109..123
    tests/AlertsTest.php on lines 136..150

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method create has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function create(Request $request)
    {
        try {
            $data = $request->all();
    Severity: Minor
    Found in app/Repositories/AlertsRepository.php - About 1 hr to fix

      Method sendFakeEmail has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function sendFakeEmail($email, $option)
    {
        try {
            $alarm = new \stdClass();
            $alarm->vehicle_fleet = 'vehicle_fleet';
      Severity: Minor
      Found in app/Repositories/AlertsRepository.php - About 1 hr to fix

        Avoid unused local variables such as '$alert'.
        Open

                $alert = factory('App\Entities\Alerts')->create();
        Severity: Minor
        Found in tests/AlertsTest.php by phpmd

        UnusedLocalVariable

        Since: 0.2

        Detects when a local variable is declared and/or assigned, but not used.

        Example

        class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

        Avoid unused local variables such as '$alert'.
        Open

                $alert = factory('App\Entities\Alerts')->create();
        Severity: Minor
        Found in tests/AlertsTest.php by phpmd

        UnusedLocalVariable

        Since: 0.2

        Detects when a local variable is declared and/or assigned, but not used.

        Example

        class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

        Avoid unused local variables such as '$alert'.
        Open

                $alert = factory('App\Entities\Alerts')->create();
        Severity: Minor
        Found in tests/AlertsTest.php by phpmd

        UnusedLocalVariable

        Since: 0.2

        Detects when a local variable is declared and/or assigned, but not used.

        Example

        class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

        Avoid unused local variables such as '$alert'.
        Open

                $alert = factory('App\Entities\Alerts')->create();
        Severity: Minor
        Found in tests/AlertsTest.php by phpmd

        UnusedLocalVariable

        Since: 0.2

        Detects when a local variable is declared and/or assigned, but not used.

        Example

        class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

        Avoid unused local variables such as '$alert'.
        Open

                $alert = factory('App\Entities\Alerts')->create();
        Severity: Minor
        Found in tests/AlertsTest.php by phpmd

        UnusedLocalVariable

        Since: 0.2

        Detects when a local variable is declared and/or assigned, but not used.

        Example

        class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

        Line exceeds 120 characters; contains 157 characters
        Open

            'AlertSubject' => 'ALERTA: Veículo número :vehicle_number de placa :vehicle_plate possui pneus que precisa(m) de manutenção',
        Severity: Minor
        Found in resources/lang/pt-br/mails.php by phpcodesniffer
        Severity
        Category
        Status
        Source
        Language