alientronics/fleetany-api

View on GitHub
app/Http/Controllers/AlertController.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method sendAlertTireMail has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function sendAlertTireMail($company, $vehicle_id, $tireSensor, $ideal_pressure, $users)
    {
        try {
            $vehicle = Vehicle::where('id', $vehicle_id)->first();
    
Severity: Major
Found in app/Http/Controllers/AlertController.php - About 2 hrs to fix

    Method sendAlertTireMail has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function sendAlertTireMail($company, $vehicle_id, $tireSensor, $ideal_pressure, $users)
    Severity: Minor
    Found in app/Http/Controllers/AlertController.php - About 35 mins to fix

      Function sendAlertTireMail has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function sendAlertTireMail($company, $vehicle_id, $tireSensor, $ideal_pressure, $users)
          {
              try {
                  $vehicle = Vehicle::where('id', $vehicle_id)->first();
          
      Severity: Minor
      Found in app/Http/Controllers/AlertController.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '41', column '30').
      Open

                      $alarm = new \stdClass();

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid using static access to class '\Illuminate\Support\Facades\Log' in method 'sendAlertTireMail'.
      Open

                  Log::info($e->getMessage());

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Illuminate\Support\Facades\Lang' in method 'sendAlertTireMail'.
      Open

                                      "subject" => Lang::get('mails.AlertSubject'),

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Illuminate\Support\Facades\Log' in method 'sendAlertTireMail'.
      Open

                          Log::info('TireSensor Alert Fail: '.$e->getMessage());

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The parameter $ideal_pressure is not named in camelCase.
      Open

          public function sendAlertTireMail($company, $vehicle_id, $tireSensor, $ideal_pressure, $users)
          {
              try {
                  $vehicle = Vehicle::where('id', $vehicle_id)->first();
          

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
          public function doSomething($user_name) {
          }
      }

      Source

      The parameter $vehicle_id is not named in camelCase.
      Open

          public function sendAlertTireMail($company, $vehicle_id, $tireSensor, $ideal_pressure, $users)
          {
              try {
                  $vehicle = Vehicle::where('id', $vehicle_id)->first();
          

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
          public function doSomething($user_name) {
          }
      }

      Source

      The variable $ideal_pressure is not named in camelCase.
      Open

          public function sendAlertTireMail($company, $vehicle_id, $tireSensor, $ideal_pressure, $users)
          {
              try {
                  $vehicle = Vehicle::where('id', $vehicle_id)->first();
          

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $vehicle_id is not named in camelCase.
      Open

          public function sendAlertTireMail($company, $vehicle_id, $tireSensor, $ideal_pressure, $users)
          {
              try {
                  $vehicle = Vehicle::where('id', $vehicle_id)->first();
          

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $vehicle_id is not named in camelCase.
      Open

          public function sendAlertTireMail($company, $vehicle_id, $tireSensor, $ideal_pressure, $users)
          {
              try {
                  $vehicle = Vehicle::where('id', $vehicle_id)->first();
          

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      There are no issues that match your filters.

      Category
      Status