Sign upLogin

alientronics/fleetany-api

View on GitHub
Star
app/Http/Controllers/TripController.php

Summary

Maintainability
A
1 hr
Test Coverage

Method create has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function create(Request $request)
    {
        try {
            $inputs = $request->all();
            $user = User::where('email', $inputs['email'])->first();
Severity: Minor
Found in app/Http/Controllers/TripController.php - About 1 hr to fix

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $inputsCreate['company_id'] = $user->company_id;
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $inputsCreate['fuel_amount'] = $inputs['fuel_amount'];
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $inputsCreate['driver_id'] = $user->contact->id;
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $inputsCreate['end_mileage'] = $inputs['end_mileage'];
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $inputsCreate['tank_fill_up'] = $inputs['tank_fill_up'];
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $inputsCreate['trip_type_id'] = $type->id;
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $inputsCreate['pickup_date'] = Carbon::now();
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $inputsCreate['fuel_type'] = $inputs['fuel_type'];
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $Trip = Trip::forceCreate($inputsCreate);
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $type = Type::where('company_id', $inputsCreate['company_id'])
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $inputsCreate['vehicle_id'] = $inputs['vehicle_id'];
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$inputsCreate' which will lead to PHP notices.
    Open

                $inputsCreate['fuel_cost'] = $inputs['fuel_cost'];
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Missing class import via use statement (line '63', column '21').
    Open

            return (new \Illuminate\Http\Response)->setStatusCode($statusCode);
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\App\Entities\Trip' in method 'create'.
    Open

                $Trip = Trip::forceCreate($inputsCreate);
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Entities\Trip' in method 'index'.
    Open

            $Trips = Trip::all();
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Carbon\Carbon' in method 'create'.
    Open

                $inputsCreate['pickup_date'] = Carbon::now();
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method create uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $statusCode = 400;
            }
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\Log' in method 'create'.
    Open

                Log::info($e->getMessage());
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The variable $Trips is not named in camelCase.
    Open

        public function index()
    {
  
        $Trips = Trip::all();
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $Trip is not named in camelCase.
    Open

        public function create(Request $request)
    {
        try {
            $inputs = $request->all();
            $user = User::where('email', $inputs['email'])->first();
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $Trips is not named in camelCase.
    Open

        public function index()
    {
  
        $Trips = Trip::all();
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $Trip is not named in camelCase.
    Open

        public function create(Request $request)
    {
        try {
            $inputs = $request->all();
            $user = User::where('email', $inputs['email'])->first();
    Severity: Minor
    Found in app/Http/Controllers/TripController.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status