Sign upLogin

alientronics/fleetany-api

View on GitHub
Star

Showing 235 of 235 total issues

The variable $ideal_pressure is not named in camelCase.
Open

    public function getAlertType($company, $tireSensor, $ideal_pressure)
    {
        $alertType = [];
        if ((((1 - $company->delta_pressure) * $ideal_pressure) - 1.5) > $tireSensor->pressure) {
            $alertType['type'] = Lang::get('mails.Pressure');
Severity: Minor
Found in app/Http/Controllers/TireConditionController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Trips is not named in camelCase.
Open

    public function index()
    {
  
        $Trips = Trip::all();
Severity: Minor
Found in app/Http/Controllers/TripController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $entry_type is not named in camelCase.
Open

    private function generateEntry($company, $tireSensor, $ideal_pressure)
    {
        if (!$this->hasPressureIssue($company, $tireSensor, $ideal_pressure)) {
            $tireSensor = TireSensor::where('part_id', $tireSensor->part_id)
                ->where('created_at', '<', $tireSensor->created_at)
Severity: Minor
Found in app/Http/Controllers/TireConditionController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tiresensor_id is not named in camelCase.
Open

    public function checkTireCondition($company_id, $tiresensor_id, $vehicle_id)
    {
        $tireSensor = TireSensor::find($tiresensor_id);
        $company = Company::where('id', $company_id)->first();
Severity: Minor
Found in app/Http/Controllers/TireConditionController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TireSensor is not named in camelCase.
Open

    public function index()
    {
  
        $TireSensor = TireSensor::all();
Severity: Minor
Found in app/Http/Controllers/TireSensorController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $vehicle_id is not named in camelCase.
Open

    public function checkTireCondition($company_id, $tiresensor_id, $vehicle_id)
    {
        $tireSensor = TireSensor::find($tiresensor_id);
        $company = Company::where('id', $company_id)->first();
Severity: Minor
Found in app/Http/Controllers/TireConditionController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ideal_pressure is not named in camelCase.
Open

    private function hasPressureIssue($company, $tireSensor, $ideal_pressure)
    {
        $alertType = $this->getAlertType($company, $tireSensor, $ideal_pressure);
        if (empty($alertType['id']) ||
            ($alertType['id'] != 'High Pressure' && $alertType['id'] != 'Low Pressure')) {
Severity: Minor
Found in app/Http/Controllers/TireConditionController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Users is not named in camelCase.
Open

    public function index()
    {
  
        $Users = User::all();
Severity: Minor
Found in app/Http/Controllers/UserController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ideal_pressure is not named in camelCase.
Open

    public function getAlertType($company, $tireSensor, $ideal_pressure)
    {
        $alertType = [];
        if ((((1 - $company->delta_pressure) * $ideal_pressure) - 1.5) > $tireSensor->pressure) {
            $alertType['type'] = Lang::get('mails.Pressure');
Severity: Minor
Found in app/Http/Controllers/TireConditionController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TireSensor is not named in camelCase.
Open

    public function index()
    {
  
        $TireSensor = TireSensor::all();
Severity: Minor
Found in app/Http/Controllers/TireSensorController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $Trip is not named in camelCase.
Open

    public function create(Request $request)
    {
        try {
            $inputs = $request->all();
            $user = User::where('email', $inputs['email'])->first();
Severity: Minor
Found in app/Http/Controllers/TripController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ideal_pressure is not named in camelCase.
Open

    public function checkTireCondition($company_id, $tiresensor_id, $vehicle_id)
    {
        $tireSensor = TireSensor::find($tiresensor_id);
        $company = Company::where('id', $company_id)->first();
Severity: Minor
Found in app/Http/Controllers/TireConditionController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $entry_type is not named in camelCase.
Open

    private function generateEntry($company, $tireSensor, $ideal_pressure)
    {
        if (!$this->hasPressureIssue($company, $tireSensor, $ideal_pressure)) {
            $tireSensor = TireSensor::where('part_id', $tireSensor->part_id)
                ->where('created_at', '<', $tireSensor->created_at)
Severity: Minor
Found in app/Http/Controllers/TireConditionController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $entry_type is not named in camelCase.
Open

    private function generateEntry($company, $tireSensor, $ideal_pressure)
    {
        if (!$this->hasPressureIssue($company, $tireSensor, $ideal_pressure)) {
            $tireSensor = TireSensor::where('part_id', $tireSensor->part_id)
                ->where('created_at', '<', $tireSensor->created_at)
Severity: Minor
Found in app/Http/Controllers/TireConditionController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ideal_pressure is not named in camelCase.
Open

    private function generateEntry($company, $tireSensor, $ideal_pressure)
    {
        if (!$this->hasPressureIssue($company, $tireSensor, $ideal_pressure)) {
            $tireSensor = TireSensor::where('part_id', $tireSensor->part_id)
                ->where('created_at', '<', $tireSensor->created_at)
Severity: Minor
Found in app/Http/Controllers/TireConditionController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

Severity
Category
Status
Source
Language