Sign upLogin

alientronics/fleetany-attributes

View on GitHub
Star

Showing 32 of 32 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace App\Http\Controllers\MySql;

use App\Entities\MySql;
Severity: Major
Found in app/Http/Controllers/MySql/KeyControllerMySql.php and 2 other locations - About 4 hrs to fix
app/Http/Controllers/DynamoDb/KeyControllerDynamoDb.php on lines 1..51
app/Http/Controllers/MongoDb/KeyControllerMongoDb.php on lines 1..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace App\Http\Controllers\MongoDb;

use App\Entities\MongoDb;
Severity: Major
Found in app/Http/Controllers/MongoDb/KeyControllerMongoDb.php and 2 other locations - About 4 hrs to fix
app/Http/Controllers/DynamoDb/KeyControllerDynamoDb.php on lines 1..51
app/Http/Controllers/MySql/KeyControllerMySql.php on lines 1..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace App\Http\Controllers\DynamoDb;

use App\Entities\DynamoDb;
Severity: Major
Found in app/Http/Controllers/DynamoDb/KeyControllerDynamoDb.php and 2 other locations - About 4 hrs to fix
app/Http/Controllers/MongoDb/KeyControllerMongoDb.php on lines 1..50
app/Http/Controllers/MySql/KeyControllerMySql.php on lines 1..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The class AcceptanceValueTestCase has 12 public methods. Consider refactoring AcceptanceValueTestCase to keep number of public methods under 10.
Open

class AcceptanceValueTestCase extends TestCase
{
    /**
     * Creates the application.
     *
Severity: Minor
Found in tests/AcceptanceValueTestCase.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testValuePostSuccess()
    {
    
        $user = factory('App\User')->make();
Severity: Major
Found in tests/AcceptanceValueTestCase.php and 1 other location - About 2 hrs to fix
tests/AcceptanceValueTestCase.php on lines 98..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testValueWithModelPostSuccess()
    {
    
        $user = factory('App\User')->make();
Severity: Major
Found in tests/AcceptanceValueTestCase.php and 1 other location - About 2 hrs to fix
tests/AcceptanceValueTestCase.php on lines 62..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace App\Http\Controllers\DynamoDb;

use App\Entities\DynamoDb;
Severity: Major
Found in app/Http/Controllers/DynamoDb/ValueControllerDynamoDb.php and 2 other locations - About 2 hrs to fix
app/Http/Controllers/MongoDb/ValueControllerMongoDb.php on lines 1..41
app/Http/Controllers/MySql/ValueControllerMySql.php on lines 1..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace App\Http\Controllers\MongoDb;

use App\Entities\MongoDb;
Severity: Major
Found in app/Http/Controllers/MongoDb/ValueControllerMongoDb.php and 2 other locations - About 2 hrs to fix
app/Http/Controllers/DynamoDb/ValueControllerDynamoDb.php on lines 1..40
app/Http/Controllers/MySql/ValueControllerMySql.php on lines 1..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace App\Http\Controllers\MySql;

use App\Entities\MySql;
Severity: Major
Found in app/Http/Controllers/MySql/ValueControllerMySql.php and 2 other locations - About 2 hrs to fix
app/Http/Controllers/DynamoDb/ValueControllerDynamoDb.php on lines 1..40
app/Http/Controllers/MongoDb/ValueControllerMongoDb.php on lines 1..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function set has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function set(Request $request, $entity_key, $entity_id, $company_id)
    {
        $entity = $this->entity;
        
        $files = [];
Severity: Minor
Found in app/Repositories/ValueRepository.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function set has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function set(Request $request, $entity_key, $entity_id, $company_id)
    {
        $entity = $this->entity;
        
        $files = [];
Severity: Minor
Found in app/Repositories/ValueRepositoryDynamo.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function set(Request $request, $entity_key, $entity_id, $company_id)
    {
        $entity = $this->entity;
        
        $files = [];
Severity: Minor
Found in app/Repositories/ValueRepositoryDynamo.php - About 1 hr to fix

    Function searchKeys has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        private function searchKeys($company_id, $entity_key, $description)
    {
        $entity = $this->entity;

        $Keys = $entity::where('company_id', (int)$company_id);
    Severity: Minor
    Found in app/Repositories/KeyRepositoryDynamo.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method set has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function set(Request $request, $entity_key, $entity_id, $company_id)
    {
        $entity = $this->entity;
        
        $files = [];
    Severity: Minor
    Found in app/Repositories/ValueRepository.php - About 1 hr to fix

      Function seeInDatabase has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function seeInDatabase($table, array $data, $onConnection = null)
    {
        if (!empty($data)) {
            foreach ($data as $index => $element) {
                if (is_numeric($element) && $index == "value") {
      Severity: Minor
      Found in tests/acceptance/DynamoDbValueTest.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function closing brace must go on the next line following the body; found 1 blank lines before brace
      Open

      });
      Severity: Minor
      Found in app/Http/routes.php by phpcodesniffer

      Function closing brace must go on the next line following the body; found 1 blank lines before brace
      Open

          }
      Severity: Minor
      Found in app/Repositories/KeyRepository.php by phpcodesniffer

      Function closing brace must go on the next line following the body; found 1 blank lines before brace
      Open

          }
      Severity: Minor
      Found in app/Repositories/ValueRepositoryDynamo.php by phpcodesniffer

      Function closing brace must go on the next line following the body; found 1 blank lines before brace
      Open

          }
      Severity: Minor
      Found in tests/AcceptanceKeyTestCase.php by phpcodesniffer

      Function closing brace must go on the next line following the body; found 1 blank lines before brace
      Open

          }
      Severity: Minor
      Found in app/Repositories/ValueRepository.php by phpcodesniffer
      Severity
      Category
      Status
      Source
      Language