Sign upLogin

alientronics/fleetany-web-attributes

View on GitHub
Star

Showing 24 of 24 total issues

Method setValues has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function setValues($inputs)
    {

        if (config('app.attributes_api_url') == null) {
            return [];
Severity: Minor
Found in src/Alientronics/FleetanyWebAttributes/Repositories/AttributeRepositoryEloquent.php - About 1 hr to fix

    Method getAttributesWithValues has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function getAttributesWithValues($entity_key, $entity_id)
    {

        if (config('app.attributes_api_url') == null) {
            return [];
    Severity: Minor
    Found in src/Alientronics/FleetanyWebAttributes/Repositories/AttributeRepositoryEloquent.php - About 1 hr to fix

      Function setValues has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function setValues($inputs)
    {

        if (config('app.attributes_api_url') == null) {
            return [];
      Severity: Minor
      Found in src/Alientronics/FleetanyWebAttributes/Repositories/AttributeRepositoryEloquent.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getAttributesWithValues has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getAttributesWithValues($entity_key, $entity_id)
    {

        if (config('app.attributes_api_url') == null) {
            return [];
      Severity: Minor
      Found in src/Alientronics/FleetanyWebAttributes/Repositories/AttributeRepositoryEloquent.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Each class must be in a file by itself
      Open

      class HelperRepository {
      Severity: Minor
      Found in helper/Controller.php by phpcodesniffer

      Opening brace of a class must be on the line after the definition
      Open

      class HelperRepository {
      Severity: Minor
      Found in helper/Controller.php by phpcodesniffer

      Opening brace of a class must be on the line after the definition
      Open

      class TypeRepositoryEloquent {
      Severity: Minor
      Found in helper/TypeRepositoryEloquent.php by phpcodesniffer

      Opening brace of a class must be on the line after the definition
      Open

      class MockObject {
      Severity: Minor
      Found in helper/MockObject.php by phpcodesniffer

      Function create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function create()
    {
        $attribute = (object)[
                'id'=>'',
                'entity_key'=>'',
      Severity: Minor
      Found in src/Alientronics/FleetanyWebAttributes/Controllers/AttributeController.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in helper/MockObject.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public static function getTypes() {
      Severity: Minor
      Found in helper/TypeRepositoryEloquent.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open
      Severity: Minor
      Found in src/translations/pt-br/attributes.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return [];
      Severity: Minor
      Found in helper/MockObject.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in helper/TypeRepositoryEloquent.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function toArray() {
      Severity: Minor
      Found in helper/MockObject.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return new MockObject();
      Severity: Minor
      Found in helper/TypeRepositoryEloquent.php by phpcodesniffer

      Expected 1 newline at end of file; 0 found
      Open

      }
      Severity: Minor
      Found in helper/Controller.php by phpcodesniffer

      Expected 1 newline at end of file; 0 found
      Open

      }
      Severity: Minor
      Found in helper/MockObject.php by phpcodesniffer

      Opening brace should be on a new line
      Open

          public function getFilters() { }
      Severity: Minor
      Found in helper/Controller.php by phpcodesniffer

      Opening brace should be on a new line
      Open

          public static function getTypes() {
      Severity: Minor
      Found in helper/TypeRepositoryEloquent.php by phpcodesniffer
      Severity
      Category
      Status
      Source
      Language