Showing 27 of 27 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
return [
'quantity' => 'Quantidade',
'alert_type' => 'Tipo do Alerta',- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 205.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
return [
'quantity' => 'Quantity',
'alert_type' => 'Alert Type',- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 205.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Each class must be in a file by itself Open
class HelperRepository {- Exclude checks
Opening brace of a class must be on the line after the definition Open
class HelperRepository {- Exclude checks
Opening brace of a class must be on the line after the definition Open
class FleetRepositoryEloquent {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Route::get('/reports/alerts/{entity_type}/{entity_id}', '\Alientronics\FleetanyWebReports\Controllers\ReportController@alertsReport');- Exclude checks
Line exceeds 120 characters; contains 142 characters Open
Route::get('/reports/alerts/{entity_type}/{entity_id}', '\Alientronics\FleetanyWebReports\Controllers\ReportController@alertsReport');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Route::get('/reports/alerts/{entity_type}/{entity_id}/type/{alert_type}', '\Alientronics\FleetanyWebReports\Controllers\ReportController@alertTypeReport');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Route::get('/reports/alerts/tires', '\App\Http\Controllers\TireController@index');- Exclude checks
Line exceeds 120 characters; contains 136 characters Open
Route::get('/reports/vehicles/maintenance', '\Alientronics\FleetanyWebReports\Controllers\VehicleReportController@maintenance');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Route::get('/reports/alerts/vehicles', '\App\Http\Controllers\VehicleController@index');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Route::get('/reports/vehicles', '\Alientronics\FleetanyWebReports\Controllers\VehicleReportController@index');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public static function getTireSensorHistoricalData() {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public static function setColumnsChart() {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return true;- Exclude checks
Line exceeds 120 characters; contains 163 characters Open
Route::get('/reports/alerts/{entity_type}/{entity_id}/type/{alert_type}', '\Alientronics\FleetanyWebReports\Controllers\ReportController@alertTypeReport');- Exclude checks
Line exceeds 120 characters; contains 131 characters Open
Route::get('/reports/tires/maintenance', '\Alientronics\FleetanyWebReports\Controllers\TiresReportController@maintenance');- Exclude checks