Sign upLogin

alientronics/fleetany-web

View on GitHub
Star
app/Http/Controllers/VehicleController.php

Summary

Maintainability
D
3 days
Test Coverage

File VehicleController.php has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers;

use App\Http\Controllers\Controller;
Severity: Minor
Found in app/Http/Controllers/VehicleController.php - About 2 hrs to fix

    Method edit has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function edit($idVehicle)
    {
        $vehicle = $this->vehicleRepo->find($idVehicle);
        $this->helper->validateRecord($vehicle);
    Severity: Major
    Found in app/Http/Controllers/VehicleController.php - About 2 hrs to fix

      Function getLastDatetimeData has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getLastDatetimeData($tireData)
    {
        $lastData = "";
        if (!empty($tireData)) {
            foreach ($tireData as $position => $value) {
      Severity: Minor
      Found in app/Http/Controllers/VehicleController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function vehicleHistory has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private function vehicleHistory($fleetData, $dateIni, $dateEnd)
    {
        $tireSensorData['positions'] = [];
        $partsIds = [];
        if (!empty($fleetData['tireData'])) {
      Severity: Minor
      Found in app/Http/Controllers/VehicleController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method show has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function show($idVehicle, $dateIni = null, $dateEnd = null)
    {
        $vehicle = $this->vehicleRepo->find($idVehicle);
        $this->helper->validateRecord($vehicle);
        $fleetData = $this->fleetRepo->getFleetData($vehicle->id);
      Severity: Minor
      Found in app/Http/Controllers/VehicleController.php - About 1 hr to fix

        Method vehicleHistory has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function vehicleHistory($fleetData, $dateIni, $dateEnd)
    {
        $tireSensorData['positions'] = [];
        $partsIds = [];
        if (!empty($fleetData['tireData'])) {
        Severity: Minor
        Found in app/Http/Controllers/VehicleController.php - About 1 hr to fix

          Function getFleetSensorDatetimeData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getFleetSensorDatetimeData($fleetTireData)
    {
        if (!empty($fleetTireData)) {
            foreach ($fleetTireData as $idVehicle => $tireData) {
                $lastDatetimeData = $this->getLastDatetimeData($tireData);
          Severity: Minor
          Found in app/Http/Controllers/VehicleController.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public function update($idVehicle)
    {
        try {
            $vehicle = $this->vehicleRepo->find($idVehicle);
            $this->helper->validateRecord($vehicle);
          Severity: Major
          Found in app/Http/Controllers/VehicleController.php and 2 other locations - About 5 hrs to fix
          app/Http/Controllers/ContactController.php on lines 116..136
          app/Http/Controllers/TripController.php on lines 130..149

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 191.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function destroy($idVehicle)
    {
        $hasReferences = $this->vehicleRepo->hasReferences($idVehicle);
        $vehicle = $this->vehicleRepo->find($idVehicle);
        if ($vehicle && !$hasReferences) {
          Severity: Major
          Found in app/Http/Controllers/VehicleController.php and 3 other locations - About 4 hrs to fix
          app/Http/Controllers/ContactController.php on lines 138..152
          app/Http/Controllers/ModelController.php on lines 111..125
          app/Http/Controllers/TypeController.php on lines 111..125

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 173.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function store()
    {
        try {
            $this->vehicleRepo->validator();
            $inputs = $this->vehicleRepo->setInputs($this->request->all());
          Severity: Major
          Found in app/Http/Controllers/VehicleController.php and 3 other locations - About 3 hrs to fix
          app/Http/Controllers/ContactController.php on lines 68..85
          app/Http/Controllers/PartController.php on lines 89..106
          app/Http/Controllers/TripController.php on lines 76..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 158.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status