Function getFleetData
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
public function getFleetData($vehicle_id = null)
{
$vehicles = Vehicle::where('company_id', Auth::user()['company_id']);
if (!empty($vehicle_id)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getFleetTireAndSensorData
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function getFleetTireAndSensorData($updateDatetime = null, $vehicleId = null)
{
$parts = $this->getFleetTireAndSensorParts($partsData, $vehicleId);
Method getFleetData
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getFleetData($vehicle_id = null)
{
$vehicles = Vehicle::where('company_id', Auth::user()['company_id']);
if (!empty($vehicle_id)) {
Function setColumnsChart
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function setColumnsChart($tireSensorData)
{
$chartElements[1] = "temperature";
$chartElements[2] = "pressure";
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getHistoricalData
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
private function getHistoricalData($historicalDataPos)
{
$historicalData = [];
$historicalOrderData = [];
$positionOrder = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getFleetTireAndSensorData
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
private function getFleetTireAndSensorData($updateDatetime = null, $vehicleId = null)
{
$parts = $this->getFleetTireAndSensorParts($partsData, $vehicleId);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getTireSensorHistoricalData
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function getTireSensorHistoricalData($partsIds, $dateIni, $dateEnd)
{
$this->getFleetTireAndSensorParts($partsData, null, $partsIds);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid using App\Repositories\count() function in for loops. Open
for ($i = $positionOrder; $i < count($historicalDataPos); $i++) {
$historicalData[$countPoints][substr($dataPos->created_at, 11)] .= ", null, null";
}
- Read upRead up
- Exclude checks
CountInLoopExpression
Since: 2.7.0
Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.
Example
class Foo {
public function bar()
{
$array = array();
for ($i = 0; count($array); $i++) {
// ...
}
}
}
Source https://phpmd.org/rules/design.html#countinloopexpression
Avoid using App\Repositories\count() function in for loops. Open
for ($index = 1; $index <= count($chartElements); $index++) {
$tireSensorData['columns'][$value][] = ($key * count($chartElements)) + $index;
}
- Read upRead up
- Exclude checks
CountInLoopExpression
Since: 2.7.0
Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.
Example
class Foo {
public function bar()
{
$array = array();
for ($i = 0; count($array); $i++) {
// ...
}
}
}