Sign upLogin

alientronics/fleetany-web

View on GitHub
Star

Showing 188 of 188 total issues

Function createDate has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    function createDate (y, m, d, h, M, s, ms) {
Severity: Major
Found in public/js/moment.js - About 50 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public static function getLastsFuelCostStatistics()
    {
        $statistics = [];
        $date = Carbon::now()->addMonthNoOverflow();
        for ($i = 0; $i < 6; $i++) {
    Severity: Minor
    Found in app/Repositories/TripRepositoryEloquent.php and 1 other location - About 50 mins to fix
    app/Repositories/EntryRepositoryEloquent.php on lines 120..130

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public static function getLastsServiceCostStatistics()
    {
        $statistics = [];
        $date = Carbon::now()->addMonthNoOverflow();
        for ($i = 0; $i < 6; $i++) {
    Severity: Minor
    Found in app/Repositories/EntryRepositoryEloquent.php and 1 other location - About 50 mins to fix
    app/Repositories/TripRepositoryEloquent.php on lines 125..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function getFiltersSortUrl has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getFiltersSortUrl($filters, Request $request)
    {
        $sortUrl = http_build_query($filters['sort_url']);
        foreach (array_keys($filters['sort_url']) as $key) {
            $url = $request->path() . '?' . $sortUrl . "&sort=" . $key;
    Severity: Minor
    Found in app/Repositories/HelperRepository.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function testCreate()
    {
        $this->visit('/type')->see('<a href="'.$this->baseUrl.'/type/create');
        
        $this->visit('/type/create');
    Severity: Minor
    Found in tests/acceptance/TypeControllerTest.php and 1 other location - About 40 mins to fix
    tests/acceptance/CompanyControllerTest.php on lines 19..36

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function testCreate()
    {
        $this->visit('/company')->see('<a href="'.$this->baseUrl.'/company/create');
        
        $this->visit('/company/create');
    Severity: Minor
    Found in tests/acceptance/CompanyControllerTest.php and 1 other location - About 40 mins to fix
    tests/acceptance/TypeControllerTest.php on lines 19..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Consider simplifying this complex logical expression.
    Open

            if (!((milliseconds >= 0 && days >= 0 && months >= 0) ||
                (milliseconds <= 0 && days <= 0 && months <= 0))) {
            milliseconds += absCeil(monthsToDays(months) + days) * 864e5;
            days = 0;
            months = 0;
    Severity: Major
    Found in public/js/moment.js - About 40 mins to fix

      Function createLocalOrUTC has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          function createLocalOrUTC (input, format, locale, strict, isUTC) {
      Severity: Minor
      Found in public/js/moment.js - About 35 mins to fix

        Function substituteTimeAgo has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function substituteTimeAgo(string, number, withoutSuffix, isFuture, locale) {
        Severity: Minor
        Found in public/js/moment.js - About 35 mins to fix

          Function list has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function list (format, index, field, count, setter) {
          Severity: Minor
          Found in public/js/moment.js - About 35 mins to fix

            Function getSetWeekYearHelper has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                function getSetWeekYearHelper(input, week, weekday, dow, doy) {
            Severity: Minor
            Found in public/js/moment.js - About 35 mins to fix

              Function dayOfYearFromWeeks has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  function dayOfYearFromWeeks(year, week, weekday, dow, doy) {
              Severity: Minor
              Found in public/js/moment.js - About 35 mins to fix

                Function setWeekAll has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    function setWeekAll(weekYear, week, weekday, dow, doy) {
                Severity: Minor
                Found in public/js/moment.js - About 35 mins to fix

                  Function setInputs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function setInputs($inputs, $user = null)
    {
        $typeId = Type::where('entity_key', 'contact')
                                            ->where('name', 'detail')
                                            ->where('company_id', Auth::user()['company_id'])
                  Severity: Minor
                  Found in app/Repositories/UserRepositoryEloquent.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getTypes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function getTypes($entity_key = null)
    {
        $types = Type::where('company_id', Auth::user()['company_id']);
        
        if (!empty($entity_key)) {
                  Severity: Minor
                  Found in app/Repositories/TypeRepositoryEloquent.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getTireSensorHistoricalData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getTireSensorHistoricalData($partsIds, $dateIni, $dateEnd)
    {
        
        $this->getFleetTireAndSensorParts($partsData, null, $partsIds);
                  Severity: Minor
                  Found in app/Repositories/FleetRepositoryEloquent.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function setPositions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function setPositions($parts)
    {
        if (!empty($parts)) {
            foreach ($parts as $index => $part) {
                if ($part->part_type != "tire" && $part->part_type != "sensor") {
                  Severity: Minor
                  Found in app/Repositories/PartRepositoryEloquent.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function setTiresColor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function setTiresColor($tiresData, $sensor, $objTire)
    {
        if (!empty($tiresData['parts'][$sensor->part_id])
            && ($sensor->pressure > $tiresData['dangerMaxPressure']
                || $sensor->pressure < $tiresData['dangerMinPressure']
                  Severity: Minor
                  Found in app/Repositories/VehicleRepositoryEloquent.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getFleetTireAndSensorData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function getFleetTireAndSensorData($updateDatetime = null, $vehicleId = null)
    {
        
        $parts = $this->getFleetTireAndSensorParts($partsData, $vehicleId);
                  Severity: Minor
                  Found in app/Repositories/FleetRepositoryEloquent.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getVehiclesGeofence has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private static function getVehiclesGeofence($vehicles)
    {
        if (!empty($vehicles)) {
            foreach ($vehicles as $index => $vehicle) {
                if (empty($vehicle['geofence'])) {
                  Severity: Minor
                  Found in app/Repositories/VehicleRepositoryEloquent.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language