Sign upLogin

alsatian-test/alsatian

View on GitHub
Star

Showing 54 of 54 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @TestCase(new ExtensionContextBuilder().build())
    @TestCase(new ExtensionContextBuilder().build())
    @Test("activate sets up debug test command")
    public activateDebugTestCommand(context: ExtensionContext) {
Severity: Major
Found in packages/vscode-extension/src/extension.spec.ts and 2 other locations - About 5 hrs to fix
packages/vscode-extension/src/extension.spec.ts on lines 45..58
packages/vscode-extension/src/extension.spec.ts on lines 60..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 143.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @TestCase(new ExtensionContextBuilder().build())
    @TestCase(new ExtensionContextBuilder().build())
    @Test("activate sets up run test fixture command")
    public activateRunFixtureCommand(context: ExtensionContext) {
Severity: Major
Found in packages/vscode-extension/src/extension.spec.ts and 2 other locations - About 5 hrs to fix
packages/vscode-extension/src/extension.spec.ts on lines 30..43
packages/vscode-extension/src/extension.spec.ts on lines 60..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 143.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @TestCase(new ExtensionContextBuilder().build())
    @TestCase(new ExtensionContextBuilder().build())
    @Test("activate sets up code lens provider")
    public activateCodeLens(context: ExtensionContext) {
Severity: Major
Found in packages/vscode-extension/src/extension.spec.ts and 2 other locations - About 5 hrs to fix
packages/vscode-extension/src/extension.spec.ts on lines 30..43
packages/vscode-extension/src/extension.spec.ts on lines 45..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 143.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public toContain(expectedContent: ContentType) {
        this.registerMatcher(
            this.actualValue.indexOf(expectedContent) > -1 === this.shouldMatch,
            `Expected ${stringify(this.actualValue)} ${
                !this.shouldMatch ? "not " : ""
Severity: Major
Found in packages/alsatian/core/matchers/container-matcher.ts and 1 other location - About 3 hrs to fix
packages/alsatian/core/matchers/string-matcher.ts on lines 36..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public toContain(expectedContent: string) {
        this.registerMatcher(
            this.actualValue.indexOf(expectedContent) > -1 === this.shouldMatch,
            `Expected ${stringify(this.actualValue)} ${
                !this.shouldMatch ? "not " : ""
Severity: Major
Found in packages/alsatian/core/matchers/string-matcher.ts and 1 other location - About 3 hrs to fix
packages/alsatian/core/matchers/container-matcher.ts on lines 15..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.registerMatcher(
            (error === null) !== this.shouldMatch,
            `Expected an error ` +
            `${this.shouldMatch ? "" : "not "}to be thrown ` +
            `but ${this.shouldMatch ? "no errors were" : "an error was"} thrown.`,
Severity: Major
Found in packages/alsatian/core/matchers/function-matcher.ts and 1 other location - About 3 hrs to fix
packages/alsatian/core/matchers/function-matcher.ts on lines 17..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.registerMatcher(
            (error === null) !== this.shouldMatch,
            `Expected an error ` +
            `${this.shouldMatch ? "" : "not "}to be thrown ` +
            `but ${this.shouldMatch ? "no errors were" : "an error was"} thrown.`,
Severity: Major
Found in packages/alsatian/core/matchers/function-matcher.ts and 1 other location - About 3 hrs to fix
packages/alsatian/core/matchers/function-matcher.ts on lines 32..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function loadTestFixtureInstance has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private loadTestFixtureInstance(
        testFixtureConstructor: new () => object,
        defaultFixtureDescription: string,
        filePath: string
    ): ITestFixture | null {
Severity: Major
Found in packages/alsatian/core/test-loader.ts - About 3 hrs to fix

    Function execute has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        public static async execute(fileName: string, fixtureName: string, testName: string, range: Range, execArgv?: string[]) {
        if (styles[testName]) {
            styles[testName].dispose();
        }
    Severity: Minor
    Found in packages/vscode-extension/src/commands/run-test-command.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

       private buffersEqual(expectedValue: T) {
       this.registerMatcher(
           this.checkBuffersAreEqual(
               expectedValue,
               this.actualValue
    Severity: Major
    Found in packages/alsatian/core/matchers/object-matcher.ts and 1 other location - About 2 hrs to fix
    packages/alsatian/core/matchers/object-matcher.ts on lines 64..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private objectsEqual(expectedValue: T) {
        this.registerMatcher(
            this.checkObjectsAreDeepEqual(
                expectedValue,
                this.actualValue
    Severity: Major
    Found in packages/alsatian/core/matchers/object-matcher.ts and 1 other location - About 2 hrs to fix
    packages/alsatian/core/matchers/object-matcher.ts on lines 20..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function execute has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static async execute(fileName: string, fixtureName: string, testName: string, range: Range, execArgv?: string[]) {
        if (styles[testName]) {
            styles[testName].dispose();
        }
    Severity: Major
    Found in packages/vscode-extension/src/commands/run-test-command.ts - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            return `Pass: ${passCount}/${this.totalTests}\n`
           + `Fail: ${failCount}/${this.totalTests}\n`
           + `Not Run: ${notRunCount}/${this.totalTests}\n`
           + `Skipped: ${skipCount}/${this.totalTests}`;
      Severity: Major
      Found in packages/vscode-extension/src/tree-view/alsatian-test-tree-view-item.ts and 1 other location - About 2 hrs to fix
      packages/vscode-extension/src/tree-view/alsatian-test-fixture-tree-view-item.ts on lines 78..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          return `Pass: ${passCount}/${this.totalTests}\n`
         + `Fail: ${failCount}/${this.totalTests}\n`
         + `Not Run: ${notRunCount}/${this.totalTests}\n`
         + `Skipped: ${skipCount}/${this.totalTests}`;
      Severity: Major
      Found in packages/vscode-extension/src/tree-view/alsatian-test-fixture-tree-view-item.ts and 1 other location - About 2 hrs to fix
      packages/vscode-extension/src/tree-view/alsatian-test-tree-view-item.ts on lines 54..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function runTest has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public async runTest(fileName: string, fixtureName: string, testName?: string, execArgv?: string[]) {

        const eventData = {
            fileName,
            fixtureName,
      Severity: Major
      Found in packages/vscode-extension/src/running/test-runner.ts - About 2 hrs to fix

        Function subscription has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                const subscription = RunTestCommand.testRunner.subscribe(event => {

            if (
                event.payload.fileName !== fileName
                || event.payload.fixtureName !== fixtureName
        Severity: Major
        Found in packages/vscode-extension/src/commands/run-test-command.ts - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @Test("finds file in a parent directory")
    public async findsFileInParent() {
        const directory = join(__dirname, "icons");

        const file = await findNearestFile("find-nearest-file.ts", directory);
          Severity: Major
          Found in packages/vscode-extension/src/find-nearest-file.spec.ts and 1 other location - About 1 hr to fix
          packages/vscode-extension/src/find-nearest-file.spec.ts on lines 37..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @Test("finds file in another directory")
    public async findFileInAnotherDirectory() {
        const directory = join(__dirname, "icons");

        const file = await findNearestFile("success.svg", directory);
          Severity: Major
          Found in packages/vscode-extension/src/find-nearest-file.spec.ts and 1 other location - About 1 hr to fix
          packages/vscode-extension/src/find-nearest-file.spec.ts on lines 48..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  const message = await new Promise<IMessage>(resolve => {
            runProcess.on("message", msg => {
                if (msg.type === "testComplete") {
                    resolve(msg);
                }
          Severity: Major
          Found in packages/vscode-extension/src/run.spec.ts and 2 other locations - About 1 hr to fix
          packages/vscode-extension/src/run.spec.ts on lines 23..29
          packages/vscode-extension/src/run.spec.ts on lines 49..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  const message = await new Promise<IMessage>(resolve => {
            runProcess.on("message", msg => {
                if (msg.type === "testComplete") {
                    resolve(msg);
                }
          Severity: Major
          Found in packages/vscode-extension/src/run.spec.ts and 2 other locations - About 1 hr to fix
          packages/vscode-extension/src/run.spec.ts on lines 49..55
          packages/vscode-extension/src/run.spec.ts on lines 74..80

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language