Sign upLogin

alsutton/enterprisepasswordsafe

View on GitHub
Star

Showing 189 of 206 total issues

Method getDefaultPermissionsForNode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void getDefaultPermissionsForNode(final String nodeId,
                                             final Map<String, PasswordPermission> userPermMap,
                                             final Map<String, PasswordPermission> groupPermMap)
            throws SQLException, GeneralSecurityException {
        if( nodeId == null )
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/database/HierarchyNodePermissionDAO.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method waitForString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void waitForString( String theString ) 
        throws IOException {        
        InputWaiter waiter;
        if            ( theString.startsWith("stdout") ) {
            waiter = new InputWaiter(stdout, theString.substring(7, theString.length()), WAIT_TIMEOUT);
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/engine/scripting/SimpleTerminalInteractor.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doGet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected void doGet(final HttpServletRequest request, final HttpServletResponse response)
            throws IOException, ServletException {
        String passwordId = ServletUtils.getInstance().getParameterValue(request, "id");
        try {
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/AlterAccess.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getByIdForTime has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public HistoricalPassword getByIdForTime(final AccessControl ac, final String id, final long dt) throws SQLException {
        if (id == null) {
            return null;
        }
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/database/HistoricalPasswordDAO.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getAll has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public List<AuthenticationSource> getAll()
        throws SQLException {
        try(Statement stmt = BOMFactory.getCurrentConntection().createStatement()) {
            try(ResultSet rs = stmt.executeQuery(GET_ALL)) {
                List<AuthenticationSource> sources = new ArrayList<>();
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/database/AuthenticationSourceDAO.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setExpiry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private void setExpiry(final HttpServletRequest request, final Password password )
            throws ParseException, ServletException, SQLException {
        final String expiry = request.getParameter("expiryDate");
        if (expiry == null || expiry.isEmpty()) {
            password.setExpiry(Long.MAX_VALUE);
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/ChangePassword.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doGet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void doGet(final HttpServletRequest request, final HttpServletResponse response)
            throws ServletException, IOException {
        String userId = request.getParameter("userId");
        if (userId == null) {
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/UserServlet.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getPermissions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    Permissions getPermissions(PreparedStatement preparedStatement)
            throws SQLException {
        Permissions permissions = new Permissions();
        try(ResultSet rs = preparedStatement.executeQuery()) {
            while( rs.next() ) {
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/database/AbstractAccessControlDAO.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method isChild has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    boolean isChild(final HierarchyNode parent, final HierarchyNode child)
            throws SQLException {
        final String parentId = parent.getNodeId();
        if (parentId.equals(HierarchyNode.ROOT_NODE_ID) || child.getParentId().equals(parentId)
        ||  parent.equals(child)) {
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/engine/nodes/HierarchyManipulator.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doGet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected void doGet(final HttpServletRequest request, final HttpServletResponse response)
        throws ServletException, IOException {

        PasswordRestriction restriction = null;
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/PasswordGeneratorServlet.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addPasswordText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private void addPasswordText(HttpServletRequest request,Password password) {
        String passwordText = password.getPassword();
        String password1 = request.getParameter("password_1");
        if(password1 == null || password1.isEmpty()) {
            request.setAttribute("password_1", passwordText);
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/EditPassword.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doPost has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected final void doPost(final HttpServletRequest request, final HttpServletResponse response)
            throws ServletException, IOException {
        try {
            User thisUser = SecurityUtils.getRemoteUser(request);
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/SearchServlet.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setNotViewing has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void setNotViewing(final User theUser, final boolean status)
            throws SQLException, GeneralSecurityException, UnsupportedEncodingException {

        MembershipDAO mDAO = MembershipDAO.getInstance();
        if(status) {
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/engine/users/UserPriviledgeTransitioner.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getMultiple has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    List<Password> getMultiple(User accessingUser, final String sql, final String... parameters)
            throws SQLException, GeneralSecurityException, IOException {
        List<Password> results = super.getMultiple(sql, parameters);
        if (results.isEmpty()) {
            return results;
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/database/PasswordStoreManipulator.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getParameterValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public String getParameterValue(final HttpServletRequest request, final String parameterName) {
        String value = (String) request.getAttribute(parameterName);
        if (value == null || value.length() == 0)
            value = request.getParameter(parameterName);
        if (value == null || value.length() == 0) {
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/utils/ServletUtils.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addExpiryDetails has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private void addExpiryDetails(HttpServletRequest request, ServletUtils servletUtils, Password password)
            throws SQLException {
        long expiryDate;
        PasswordRestriction restriction = PasswordRestrictionDAO.getInstance().getById(password.getRestrictionId());
        long expiry = password.getExpiry();
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/EditPassword.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doPost has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected void doPost( final HttpServletRequest request, final HttpServletResponse response )
            throws ServletException, IOException {

        request.setAttribute("error_page", "/admin/im_install_stage1.jsp");
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/InstallIntegrationModuleStage2.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getAccessibilityRules has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public Set<HierarchyNodeAccessRule> getAccessibilityRules( final HierarchyNode node, final Group adminGroup)
        throws SQLException, GeneralSecurityException {
        Set<HierarchyNodeAccessRule> permissions = new TreeSet<>();

        try(PreparedStatement ps = BOMFactory.getCurrentConntection().prepareStatement(GET_NODE_RULES_SQL)) {
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/database/HierarchyNodeAccessRuleDAO.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doGet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected void doGet(final HttpServletRequest request, final HttpServletResponse response)
            throws ServletException, IOException {

        try {
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/DeleteUser.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method updateAccessControl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private boolean updateAccessControl(AccessControl adminAc, AccessControl currentAccessControl,
                                        PasswordPermission permission,
                                        AccessControlBuilder<? extends AccessControl> accessControlBuilder) {
        boolean changed = false;
        if( permission.allowsRead && currentAccessControl.getReadKey() == null ) {
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/UpdateAccess.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language