Sign upLogin

alsutton/enterprisepasswordsafe

View on GitHub
Star
src/main/java/com/enterprisepasswordsafe/database/AuthenticationSourceDAO.java

Summary

Maintainability
A
50 mins
Test Coverage
F
0%

Method getAll has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public List<AuthenticationSource> getAll()
        throws SQLException {
        try(Statement stmt = BOMFactory.getCurrentConntection().createStatement()) {
            try(ResultSet rs = stmt.executeQuery(GET_ALL)) {
                List<AuthenticationSource> sources = new ArrayList<>();
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/database/AuthenticationSourceDAO.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getById has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public AuthenticationSource getById(final String sourceId)
            throws SQLException {
        if (sourceId == null || sourceId.equals(AuthenticationSource.DEFAULT_SOURCE_ID)) {
            return AuthenticationSource.DEFAULT_SOURCE;
        }
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/database/AuthenticationSourceDAO.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status