Sign upLogin

alsutton/enterprisepasswordsafe

View on GitHub
Star
src/main/java/com/enterprisepasswordsafe/database/HierarchyNodeAccessRuleDAOGroupPrecedent.java

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Method getAccessibilityForUser has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public byte getAccessibilityForUser( final String nodeId, final User user, boolean recurse)
        throws SQLException, GeneralSecurityException {
        if(nodeId == null || nodeId.equals(HierarchyNode.ROOT_NODE_ID)) {
            return ACCESIBILITY_ALLOWED;
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/database/HierarchyNodeAccessRuleDAOGroupPrecedent.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return userRule;
Severity: Major
Found in src/main/java/com/enterprisepasswordsafe/database/HierarchyNodeAccessRuleDAOGroupPrecedent.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return ACCESIBILITY_ALLOWED;
    Severity: Major
    Found in src/main/java/com/enterprisepasswordsafe/database/HierarchyNodeAccessRuleDAOGroupPrecedent.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return ACCESIBILITY_DENIED;
      Severity: Major
      Found in src/main/java/com/enterprisepasswordsafe/database/HierarchyNodeAccessRuleDAOGroupPrecedent.java - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status