Sign upLogin

alsutton/enterprisepasswordsafe

View on GitHub
Star
src/main/java/com/enterprisepasswordsafe/database/PasswordStoreManipulator.java

Summary

Maintainability
A
2 hrs
Test Coverage
D
63%

Method newInstance has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    Password newInstance(ResultSet rs)
            throws SQLException {
        Password password = new Password(rs.getString(1), rs.getBytes(1 + 1));
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/database/PasswordStoreManipulator.java - About 1 hr to fix

    Method newInstance has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    Password newInstance(ResultSet rs)
            throws SQLException {
        Password password = new Password(rs.getString(1), rs.getBytes(1 + 1));
    Severity: Minor
    Found in src/main/java/com/enterprisepasswordsafe/database/PasswordStoreManipulator.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getMultiple has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        List<Password> getMultiple(User accessingUser, final String sql, final String... parameters)
            throws SQLException, GeneralSecurityException, IOException {
        List<Password> results = super.getMultiple(sql, parameters);
        if (results.isEmpty()) {
            return results;
    Severity: Minor
    Found in src/main/java/com/enterprisepasswordsafe/database/PasswordStoreManipulator.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status