src/main/java/com/enterprisepasswordsafe/ui/web/servlets/ChangePassword.java
Method doPost
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
@Override
protected void doPost(final HttpServletRequest request, final HttpServletResponse response)
throws IOException, ServletException {
String csrfToken = request.getParameter("token");
if(csrfToken == null
Method setRestrictedAccess
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
private void setRestrictedAccess(final HttpServletRequest request, final Password password ) {
String raEnabled = request.getParameter("ra_enabled");
if( raEnabled != null && raEnabled.equals("Y") ) {
password.setRaEnabled(true);
String approvers = request.getParameter("ra_approvers");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method setExpiry
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
private void setExpiry(final HttpServletRequest request, final Password password )
throws ParseException, ServletException, SQLException {
final String expiry = request.getParameter("expiryDate");
if (expiry == null || expiry.isEmpty()) {
password.setExpiry(Long.MAX_VALUE);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"