src/main/java/com/enterprisepasswordsafe/ui/web/servlets/EditPassword.java
Method addPasswordText
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
private void addPasswordText(HttpServletRequest request,Password password) {
String passwordText = password.getPassword();
String password1 = request.getParameter("password_1");
if(password1 == null || password1.isEmpty()) {
request.setAttribute("password_1", passwordText);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method addExpiryDetails
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
private void addExpiryDetails(HttpServletRequest request, ServletUtils servletUtils, Password password)
throws SQLException {
long expiryDate;
PasswordRestriction restriction = PasswordRestrictionDAO.getInstance().getById(password.getRestrictionId());
long expiry = password.getExpiry();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"