Sign upLogin

alsutton/enterprisepasswordsafe

View on GitHub
Star
src/main/java/com/enterprisepasswordsafe/ui/web/servlets/Explorer.java

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Avoid too many return statements within this method.
Open

                return keyComparison == 0 ? passwordObject0.getId().compareTo(passwordObject1.getId()) : keyComparison;
Severity: Major
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/Explorer.java - About 30 mins to fix

    Method getClosestValidNodeToRequested has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private HierarchyNode getClosestValidNodeToRequested(HttpServletRequest request, User user, String nodeId)
            throws SQLException, GeneralSecurityException {
        HierarchyNodeDAO hnDAO = HierarchyNodeDAO.getInstance();
        HierarchyNode node = hnDAO.getById(nodeId);
        if(node == null || node.getType() == HierarchyNode.USER_CONTAINER_NODE) {
    Severity: Minor
    Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/Explorer.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method determineHierarchyEditability has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private void determineHierarchyEditability(HttpServletRequest request, User user)
            throws SQLException {
        request.setAttribute("edithierarchy_allowed", "N");
        if(userClassifier.isNonViewingUser(user)) {
            return;
    Severity: Minor
    Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/Explorer.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method compare has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            @Override
        public int compare(final Password passwordObject0, final Password passwordObject1) {
            try {
                if (passwordObject0 == passwordObject1) {
                    return 0;
    Severity: Minor
    Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/Explorer.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status