Sign upLogin

alsutton/enterprisepasswordsafe

View on GitHub
Star
src/main/java/com/enterprisepasswordsafe/ui/web/servlets/UpdateAccess.java

Summary

Maintainability
B
4 hrs
Test Coverage
F
0%

File UpdateAccess.java has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2017 Carbon Security Ltd. <opensource@carbonsecurity.co.uk>
 *
 * Permission to use, copy, modify, and distribute this software for any
 * purpose with or without fee is hereby granted, provided that the above
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/UpdateAccess.java - About 2 hrs to fix

    Method needsUpdate has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private boolean needsUpdate(AccessControl adminAc, AccessControl currentAccessControl,
                                UserAccessControlDAO accessControlDAO,
                                User entity, Password thePassword, String access,
                                AccessControlBuilder<UserAccessControl> accessControlBuilder)
    Severity: Major
    Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/UpdateAccess.java - About 50 mins to fix

      Method needsUpdate has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private boolean needsUpdate(AccessControl adminAc, AccessControl currentAccessControl,
                                GroupAccessControlDAO accessControlDAO,
                                Group entity, Password thePassword, String access,
                                AccessControlBuilder<GroupAccessControl> accessControlBuilder)
      Severity: Major
      Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/UpdateAccess.java - About 50 mins to fix

        Method updateAccessControl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private boolean updateAccessControl(AccessControl adminAc, AccessControl currentAccessControl,
                                        PasswordPermission permission,
                                        AccessControlBuilder<? extends AccessControl> accessControlBuilder) {
        boolean changed = false;
        if( permission.allowsRead && currentAccessControl.getReadKey() == null ) {
        Severity: Minor
        Found in src/main/java/com/enterprisepasswordsafe/ui/web/servlets/UpdateAccess.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status