Sign upLogin

alsutton/enterprisepasswordsafe

View on GitHub
Star
src/main/java/com/enterprisepasswordsafe/ui/web/utils/PasswordGenerator.java

Summary

Maintainability
B
4 hrs
Test Coverage
F
0%

Method generate has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public String generate( final int upperCount, final int lowerCount,
            final int numericCount, int specialCount, int minLength,
            int maxLength, final String specialChars, boolean startSpecial ) {
        if(    specialChars.length() > 0
        &&  specialCount > 0
Severity: Minor
Found in src/main/java/com/enterprisepasswordsafe/ui/web/utils/PasswordGenerator.java - About 1 hr to fix

    Method generate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public String generate( final int upperCount, final int lowerCount,
            final int numericCount, int specialCount, int minLength,
            int maxLength, final String specialChars, boolean startSpecial ) {
        if(    specialChars.length() > 0
        &&  specialCount > 0
    Severity: Minor
    Found in src/main/java/com/enterprisepasswordsafe/ui/web/utils/PasswordGenerator.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generate has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public String generate( final int upperCount, final int lowerCount,
            final int numericCount, int specialCount, int minLength,
            int maxLength, final String specialChars, boolean startSpecial ) {
    Severity: Major
    Found in src/main/java/com/enterprisepasswordsafe/ui/web/utils/PasswordGenerator.java - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status