Sign upLogin

alto/seatbelt

View on GitHub
Star

Showing 3 of 3 total issues

Avoid too many return statements within this method.
Open

      return false if unexpected_blind_copy?(mail, options)
Severity: Major
Found in lib/seatbelt/assert_mail.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return false if unexpected_body?(mail, options)
    Severity: Major
    Found in lib/seatbelt/assert_mail.rb - About 30 mins to fix

      Method got_mail? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def got_mail?(mail, options={})
      return false if unexpected_recipient?(mail, options)
      return false if unexpected_sender?(mail, options)
      return false if unexpected_subject?(mail, options)
      return false if unexpected_copy?(mail, options)
      Severity: Minor
      Found in lib/seatbelt/assert_mail.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language